Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpcsrv: drop unused method from the Ledger interface #3111

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

roman-khimov
Copy link
Member

Inspired by #3110.

@roman-khimov roman-khimov added the rpc RPC server and client label Aug 29, 2023
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #3111 (4a64869) into master (1863b79) will decrease coverage by 0.03%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3111      +/-   ##
==========================================
- Coverage   84.84%   84.82%   -0.03%     
==========================================
  Files         329      329              
  Lines       44222    44239      +17     
==========================================
+ Hits        37520    37525       +5     
- Misses       5197     5206       +9     
- Partials     1505     1508       +3     
Files Changed Coverage Δ
pkg/services/rpcsrv/server.go 80.58% <ø> (+0.13%) ⬆️

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov roman-khimov merged commit 5463a91 into master Aug 30, 2023
13 of 18 checks passed
@roman-khimov roman-khimov deleted the rpcsrv-drop-unused-iface branch August 30, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rpc RPC server and client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants