Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manifest: support NEP-24 #3560

Merged
merged 4 commits into from
Nov 20, 2024

rpcsrv: add NEP24 test

b63c7aa
Select commit
Loading
Failed to load commit list.
Merged

manifest: support NEP-24 #3560

rpcsrv: add NEP24 test
b63c7aa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 20, 2024 in 0s

82.97% (-0.06%) compared to 57eec71

View this Pull Request on Codecov

82.97% (-0.06%) compared to 57eec71

Details

Codecov Report

Attention: Patch coverage is 71.91011% with 50 lines in your changes missing coverage. Please review.

Project coverage is 82.97%. Comparing base (57eec71) to head (b63c7aa).

Files with missing lines Patch % Lines
pkg/rpcclient/nep24/royalty.go 65.45% 25 Missing and 13 partials ⚠️
pkg/smartcontract/rpcbinding/binding.go 85.93% 7 Missing and 2 partials ⚠️
pkg/smartcontract/manifest/standard/comply.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3560      +/-   ##
==========================================
- Coverage   83.02%   82.97%   -0.06%     
==========================================
  Files         334      335       +1     
  Lines       46543    46708     +165     
==========================================
+ Hits        38643    38755     +112     
- Misses       6326     6363      +37     
- Partials     1574     1590      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

View more details on Codecov