Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tx and block doc #3683

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Improve tx and block doc #3683

merged 5 commits into from
Nov 15, 2024

Conversation

roman-khimov
Copy link
Member

No description provided.

@roman-khimov roman-khimov added documentation Improvements or additions to documentation enhancement Improving existing functionality labels Nov 14, 2024
@roman-khimov roman-khimov added this to the v0.107.0 milestone Nov 14, 2024
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.05%. Comparing base (c2b4d32) to head (9cc16d7).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3683      +/-   ##
==========================================
- Coverage   83.05%   83.05%   -0.01%     
==========================================
  Files         334      334              
  Lines       46599    46599              
==========================================
- Hits        38704    38702       -2     
  Misses       6322     6322              
- Partials     1573     1575       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cachable fields behaviour caused a lot of troubles in NeoFS.

pkg/core/transaction/transaction.go Outdated Show resolved Hide resolved
pkg/core/transaction/transaction.go Outdated Show resolved Hide resolved
pkg/core/transaction/transaction.go Outdated Show resolved Hide resolved
Eventually we can drop them, but they were present for a long long time.

Signed-off-by: Roman Khimov <[email protected]>
@AnnaShaleva AnnaShaleva merged commit 5707bdd into master Nov 15, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the improve-tx-doc branch November 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement Improving existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants