cli: fix fetchLatestMissingBlockIndex and uploadIndexFiles in upload-bin command
#3684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3684 +/- ##
==========================================
- Coverage 83.05% 83.02% -0.04%
==========================================
Files 334 334
Lines 46599 46613 +14
==========================================
- Hits 38704 38699 -5
- Misses 6322 6338 +16
- Partials 1573 1576 +3 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
changed the title
upload-bin commandupload-bin command
AnnaShaleva
reviewed
Nov 15, 2024
AnnaShaleva
reviewed
Nov 15, 2024
Close #3667 Signed-off-by: Ekaterina Pavlova <[email protected]>
The expected count of index files should be counted based on the already uploaded object number. Close #3669 Signed-off-by: Ekaterina Pavlova <[email protected]>
Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
last-block
branch
from
d400fd1
to
375b095
Compare
AnnaShaleva
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3667
Close #3669