*: move metric neogo_version out of pkg/network
#3712
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
AliceInHunterland
force-pushed
the
move-metrics
branch
3 times, most recently
from
f5dd968
to
01bd55f
Compare
AnnaShaleva
reviewed
Nov 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3712 +/- ##
==========================================
- Coverage 82.83% 82.83% -0.01%
==========================================
Files 335 336 +1
Lines 46843 46845 +2
==========================================
- Hits 38803 38802 -1
- Misses 6448 6449 +1
- Partials 1592 1594 +2 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
move-metrics
branch
from
01bd55f
to
1c610e2
Compare
AnnaShaleva
reviewed
Nov 29, 2024
AnnaShaleva
reviewed
Nov 29, 2024
Close #3682 Signed-off-by: Ekaterina Pavlova <[email protected]>
AliceInHunterland
force-pushed
the
move-metrics
branch
from
1c610e2
to
ebb7149
Compare
AnnaShaleva
reviewed
Nov 29, 2024
There was a problem hiding this comment.
@AliceInHunterland, the code itself looks as expected. Have you tested it, is it ready for review?
in progress |
AnnaShaleva
changed the title
neogo_version out of pkg/network
|
Checked! |
roman-khimov
approved these changes
Nov 30, 2024
AnnaShaleva
approved these changes
Dec 2, 2024
| @@ -506,7 +506,7 @@ func startServer(ctx *cli.Context) error { | |||
| errChan := make(chan error) | |||
| rpcServer := rpcsrv.New(chain, cfg.ApplicationConfiguration.RPC, serv, oracleSrv, log, errChan) | |||
| serv.AddService(rpcServer) | |||
|
|
|||
There was a problem hiding this comment.
I'd say it's useless change, but OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3682