Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

object: Switch to object ID signature in Replicate request #294

Merged
merged 1 commit into from
Mar 5, 2024
Merged

object: Switch to object ID signature in Replicate request #294

merged 1 commit into from
Mar 5, 2024

Conversation

cthulhu-rider
Copy link
Contributor

@cthulhu-rider
object: Switch to object ID signature in Replicate request
119054a 
Previously, `ReplicateRequest` carried signature of the full object
field. Since IDs are object checksums, it's enough to sign the ID.

Signed-off-by: Leonard Lyubich <[email protected]>
@carpawell
Copy link
Member

carpawell commented Mar 5, 2024 •
edited
Loading

BTW, not sure that is a backward-compatible change.

roman-khimov
roman-khimov approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a lot of problems with replays technically, not that this patch adds it, but something that makes it more visible probably.

Regarding compatibility --- let's consider it to be a semantic fix, numbers are the same.

@roman-khimov roman-khimov merged commit 5c35354 into master Mar 5, 2024
3 checks passed
@roman-khimov roman-khimov deleted the replication-signature branch March 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@roman-khimov roman-khimov roman-khimov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cthulhu-rider @carpawell @roman-khimov