netmap: add some sane limits to rep/cbf #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
netmap/types.proto
Outdated
| // alternatives to include into container's nodes subset | ||
| // Container backup factor (CBF) controls how deep NeoFS will search for | ||
| // alternative nodes to include into container's nodes subset. In total, | ||
| // the number of container nodes is Replica count times CBF. This number |
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's try this way.
These are mostly some sanity checks, having unlimited replicas can be problematic. Limiting the overall number of nodes is important wrt signature collection, stack can't have more than 2048 elements. Explain CBF a bit better at the same time. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
replicas
branch
from
96201c0 to
c04f714
Compare
carpawell
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.