Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RPC client try more #2996

Merged
merged 5 commits into from
Nov 2, 2024
Merged

Make RPC client try more #2996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ca5297
morph: drop unused waitInterval
roman-khimov Oct 31, 2024
58090c7
morph: do not lock Notifications()
roman-khimov Oct 31, 2024
4df9208
morph: use read locks for notifications
roman-khimov Nov 1, 2024
70cd3af
morph: move long-term subscription channels to Client context
roman-khimov Nov 1, 2024
5ec3d5a
morph: drop inactive client mode, fix #2797
roman-khimov Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ attribute, which is used for container domain name in NNS contracts (#2954)
- Structure table in the SN-configuration document (#2974)
- False negative connection to NeoFS chain in multi-endpoint setup with at least one live node (#2986)
- Overriding the default container and object attributes only with the appropriate flags (#2985)
- RPC client reconnection failures leading to complete SN failure (#2797)

### Changed
- `ObjectService`'s `Put` RPC handler caches up to 10K lists of per-object sorted container nodes (#2901)
Expand Down
3 changes: 0 additions & 3 deletions cmd/neofs-node/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,9 +668,6 @@ func initBasics(c *cfg, key *keys.PrivateKey, stateStorage *state.PersistentStor
c.internalErr <- fmt.Errorf("restarting after morph connection was lost: %w", err)
}
}),
client.WithConnLostCallback(func() {
c.internalErr <- errors.New("morph connection has been lost")
}),
client.WithMinRequiredBlockHeight(fromSideChainBlock),
)
if err != nil {
Expand Down
3 changes: 0 additions & 3 deletions pkg/innerring/innerring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1077,9 +1077,6 @@ func (s *Server) createClient(ctx context.Context, p chainParams, errChan chan<-
errChan <- fmt.Errorf("internal services' restart after RPC reconnection to the %s: %w", p.name, err)
}
}),
client.WithConnLostCallback(func() {
errChan <- fmt.Errorf("%s chain connection has been lost", p.name)
}),
client.WithMinRequiredBlockHeight(p.from),
}
if p.withAutoSidechainScope {
Expand Down
Loading
Loading