acl: do not check EACL for system role #3015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EACL can not have any rules for system role since 0.38.0 (ab909a3), so performing these checks is not very helpful. Of course one can still ban the node by key, but that would make a lot of regular operations fail and broken container is not very helpful. This fixes #2972 as much as possible (containers can be cached for a longer period of time). Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3015 +/- ##
==========================================
- Coverage 22.84% 22.83% -0.01%
==========================================
Files 790 790
Lines 58344 58347 +3
==========================================
- Hits 13328 13325 -3
- Misses 44136 44141 +5
- Partials 880 881 +1 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
approved these changes
Nov 14, 2024
| } | ||
|
|
||
| if eaclRole == eaclSDK.RoleSystem { | ||
| return nil // Controlled by BasicACL, EACL can not contain any rules for system role since 0.38.0. |
There was a problem hiding this comment.
no need to make a separate condition for this, we already have the case
There was a problem hiding this comment.
also did not get it but maybe @roman-khimov has some thoughts on it
There was a problem hiding this comment.
That switch is so nice in its request role->acl role mapping that I didn't wont to interrupt the flow there. Can be changed at any time.
carpawell
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EACL can not have any rules for system role since 0.38.0 (ab909a3), so performing these checks is not very helpful. Of course one can still ban the node by key, but that would make a lot of regular operations fail and broken container is not very helpful.
This fixes #2972 as much as possible (containers can be cached for a longer period of time).