Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use tree for tags #1066

Merged
merged 4 commits into from
Jan 31, 2025
Merged

Dont use tree for tags #1066

merged 4 commits into from
Jan 31, 2025

Conversation

smallhive
Copy link
Contributor

No description provided.

@smallhive smallhive force-pushed the dont-use-tree-for-tags branch 2 times, most recently from 583e72a to 0b68d7c Compare January 30, 2025 09:58
@smallhive smallhive marked this pull request as ready for review January 30, 2025 09:59
api/layer/neofs_mock.go Outdated Show resolved Hide resolved
api/layer/neofs_mock.go Show resolved Hide resolved
api/handler/copy.go Show resolved Hide resolved
api/handler/put.go Show resolved Hide resolved
api/layer/tagging.go Show resolved Hide resolved
This change allows us to check field presence correctly.

Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive smallhive force-pushed the dont-use-tree-for-tags branch from 0b68d7c to d833f8a Compare January 31, 2025 05:42
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 23.00885% with 174 lines in your changes missing coverage. Please review.

Project coverage is 28.33%. Comparing base (63ec8ed) to head (d833f8a).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
api/layer/tagging.go 0.00% 87 Missing ⚠️
api/handler/tagging.go 8.00% 43 Missing and 3 partials ⚠️
api/handler/put.go 0.00% 11 Missing ⚠️
api/handler/copy.go 62.50% 6 Missing and 3 partials ⚠️
api/layer/neofs_mock.go 77.77% 6 Missing ⚠️
api/handler/head.go 50.00% 3 Missing and 1 partial ⚠️
api/handler/multipart_upload.go 0.00% 4 Missing ⚠️
api/layer/system_object.go 50.00% 3 Missing and 1 partial ⚠️
api/layer/compound.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
+ Coverage   27.77%   28.33%   +0.56%     
==========================================
  Files          89       89              
  Lines       15159    15102      -57     
==========================================
+ Hits         4210     4279      +69     
+ Misses      10484    10363     -121     
+ Partials      465      460       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roman-khimov roman-khimov merged commit 83c6195 into master Jan 31, 2025
13 of 20 checks passed
@roman-khimov roman-khimov deleted the dont-use-tree-for-tags branch January 31, 2025 07:48
smallhive added a commit to nspcc-dev/s3-tests that referenced this pull request Jan 31, 2025
This delay is a temporary solution. It required to be able to get the right order of objects. There is some limitation to understand what object was first in the same second. See nspcc-dev/neofs-s3-gw#1066.

Signed-off-by: Evgenii Baidakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants