Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return correct error on invalid grantee type #926

Conversation

smallhive
Copy link
Contributor

Closes #908.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f76190c) 33.68% compared to head (205f942) 33.68%.
Report is 1 commits behind head on master.

Files Patch % Lines
api/handler/acl.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #926   +/-   ##
=======================================
  Coverage   33.68%   33.68%           
=======================================
  Files          64       64           
  Lines       10834    10834           
=======================================
  Hits         3649     3649           
  Misses       6777     6777           
  Partials      408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this documented anywhere.

@smallhive
Copy link
Contributor Author

I don't see this documented anywhere.

* Only `CanonicalUser` (with hex encoded public key) and `All Users Group` are supported in [ACL](https://docs.aws.amazon.com/AmazonS3/latest/userguide/acl-overview.html).

@roman-khimov roman-khimov merged commit bdb5e35 into master Feb 8, 2024
13 of 16 checks passed
@roman-khimov roman-khimov deleted the 908-putbucketacl-unsupported-grantee-type-results-in-500-status-code branch February 8, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PutBucketACL: "unsupported grantee type" results in 500 status code
2 participants