Update to go 1.20 min #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #928. Signed-off-by: Evgenii Baidakov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 33.60% 27.97% -5.63%
==========================================
Files 64 87 +23
Lines 10860 13590 +2730
==========================================
+ Hits 3649 3802 +153
- Misses 6803 9371 +2568
- Partials 408 417 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
internal/neofs/tree.go can be simplified in strings.Trim* functions, although CutPrefix is not exactly perfect here, it's mostly that some checks are not needed.
api/layer/encryption/encryption.go can be improved to use bytes.Clone instead of open-coded copying.
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
928-update-to-go-120-min
branch
from
e1722a4 to
ff86d36
Compare
|
|
Signed-off-by: Evgenii Baidakov <[email protected]>
smallhive
force-pushed
the
928-update-to-go-120-min
branch
from
768e9aa to
31c745f
Compare
roman-khimov
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.