object: Export constant key to the expiration attribute #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constant is going to be used to work with object expiration time instead of string literal or `github.com/nspcc-dev/neofs-api-go/v2` module import. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
roman-khimov
approved these changes
Aug 30, 2023
carpawell
approved these changes
Aug 30, 2023
| // Note that the value determines exactly the last epoch of the object's | ||
| // relevance: for example, with the value N, the object is relevant in epoch N | ||
| // and expired in any epoch starting from N+1. | ||
| AttributeExpirationEpoch = object.SysAttributeExpEpoch |
There was a problem hiding this comment.
do we need "key", "system" words here?
There was a problem hiding this comment.
key is missing in existing ones, system - may be added, but i don't think user will care much and we'll have non-system expiration attribute
u think?
There was a problem hiding this comment.
i dont mind keeping it that way
There was a problem hiding this comment.
"key" is kinda obvious (in that it's not a value, but some attribute name/key). "system" as well, we don't have constants for random attributes here, we only have ones that have some meaning to the system.
So it's a good name as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.