Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage for Client ops #641

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Test coverage for Client ops #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b7300f
*: Improve UUID-related errors
cthulhu-rider Dec 10, 2024
484bd6c
client: Increase test coverage of all NeoFS ops
cthulhu-rider Nov 25, 2024
3de0e41
client: Do not lose transport errors in statistics
cthulhu-rider Dec 10, 2024
02bfbdd
client: Verify split info in responses of reading ops
cthulhu-rider Dec 10, 2024
d4cc175
client: Check presence of required fields in `Get` and `Head` responses
cthulhu-rider Dec 10, 2024
83dd031
container,netmap: Clarify message for the empty value error
cthulhu-rider Dec 10, 2024
4700d7b
client: Pre-check signer scheme in container SETEACL and DELETE ops
cthulhu-rider Dec 10, 2024
040f1b5
client: Clarify payload signature errors for container SETEACL / DELETE
cthulhu-rider Dec 10, 2024
530bbf8
client: Return more clear error on head reading from `ObjectHead`
cthulhu-rider Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
599 changes: 161 additions & 438 deletions client/accounting_test.go
View file
Open in desktop

Large diffs are not rendered by default.

1,334 changes: 1,317 additions & 17 deletions client/client_test.go
View file
Open in desktop

Large diffs are not rendered by default.

10 changes: 8 additions & 2 deletions client/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,9 @@ func (c *Client) ContainerDelete(ctx context.Context, id cid.ID, signer neofscry
if signer == nil {
return ErrMissingSigner
}
if signer.Scheme() != neofscrypto.ECDSA_DETERMINISTIC_SHA256 {
return fmt.Errorf("%w: expected ECDSA_DETERMINISTIC_SHA256 scheme", neofscrypto.ErrIncorrectSigner)
}

// sign container ID
var cidV2 refs.ContainerID
Expand All @@ -390,7 +393,7 @@ func (c *Client) ContainerDelete(ctx context.Context, id cid.ID, signer neofscry

if !prm.sigSet {
if err = prm.sig.Calculate(signer, data); err != nil {
err = fmt.Errorf("calculate signature: %w", err)
err = fmt.Errorf("calculate container ID signature: %w", err)
return err
}
}
Expand Down Expand Up @@ -596,12 +599,15 @@ func (c *Client) ContainerSetEACL(ctx context.Context, table eacl.Table, signer
err = ErrMissingEACLContainer
return err
}
if signer.Scheme() != neofscrypto.ECDSA_DETERMINISTIC_SHA256 {
return fmt.Errorf("%w: expected ECDSA_DETERMINISTIC_SHA256 scheme", neofscrypto.ErrIncorrectSigner)
}

// sign the eACL table
eaclV2 := table.ToV2()
if !prm.sigSet {
if err = prm.sig.CalculateMarshalled(signer, eaclV2, nil); err != nil {
err = fmt.Errorf("calculate signature: %w", err)
err = fmt.Errorf("calculate eACL signature: %w", err)
return err
}
}
Expand Down
Loading
Loading