Fixes and improvements of AIO tests #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
force-pushed
the
bugfix/aio-tests
branch
from
d5ced59 to
dd87066
Compare
cthulhu-rider
requested review from
roman-khimov,
smallhive and
carpawell
as code owners
cthulhu-rider
force-pushed
the
bugfix/aio-tests
branch
from
dd87066 to
174f69b
Compare
roman-khimov
reviewed
Dec 9, 2024
There was a problem hiding this comment.
I can't agree with a9aa379, these tests run sequentially, the problem is elsewhere.
yeah, this should be fixed another way. Tests run independently (and yeah - sequentially), so failed |
The fact that 'container really deleted' is already checked in 'container delete' test. Signed-off-by: Leonard Lyubich <[email protected]>
Returned readers must be closed when no error only, NPE occurs otherwise. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, some subtests were dependent from each other: - eACL must be set after container creation only; - eACL must be read after setting (existing test is not about 404 case); - any object test must be within container lifetime; - object must be downloaded after upload and before removal only; - object must be removed after upload only. Now run order is correct. Independent tests are still run independently and do not affect each other (e.g. GET and DELETE). Refs #644. Signed-off-by: Leonard Lyubich <[email protected]>
There is no 'bucket' term in NeoFS. Signed-off-by: Leonard Lyubich <[email protected]>
It can be random. The usertest package already provides one. Signed-off-by: Leonard Lyubich <[email protected]>
Signed-off-by: Leonard Lyubich <[email protected]>
The functions are pretty big, declaring vars much earlier they are used complicates readability. Signed-off-by: Leonard Lyubich <[email protected]>
They are polling, not 'pooling', and intervals, not timeouts. Signed-off-by: Leonard Lyubich <[email protected]>
More accepted approach for tests instead of defer. Signed-off-by: Leonard Lyubich <[email protected]>
Definite misuse of panics. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
bugfix/aio-tests
branch
from
174f69b to
3b910ce
Compare
roman-khimov
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.