Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: remove locked object from non owner node #898

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

evgeniiz321
Copy link
Contributor

@carpawell this is a scenario from #895 (comment), but it doesn't reproduce the original problem on 0.43.0. Nevertheless, the scenario is worth to add in any case. But for the #895 I need some help.

@evgeniiz321 evgeniiz321 force-pushed the ezayats/replication-failure branch from 9108904 to 98304fa Compare November 22, 2024 00:39
@carpawell
Copy link
Member

OK, i understood the reason: relay works and worked only for signed objects: https://github.com/nspcc-dev/neofs-node/blob/edc95f6a729d29d9fdaf6a54f4dfa5bc4d3b9c3c/pkg/services/object/put/streamer.go#L72-L73. Tombstone and any other non-regular object are ready and signed but, of course, they do not go through the relay process as it is turned off. So basically we are stuck here cause no easy public functionality for pushing already signed objects (too often we are thinking of nspcc-dev/neofs-node#952). Why it happened in our test load runs: https://github.com/nspcc-dev/neo-go/blob/e89f9fe2a417c917d40d933c1b6a5f92804d6e2d/cli/util/upload_bin.go#L597-L600, still surprised why you went this way but that is how uploader sends prepared and signed objects. It is really not a critical case as I do not know who else is going to upload objects this way (and also we have fixed it just no auto test for now).
cc @roman-khimov

@roman-khimov roman-khimov added the blocked Can't be done because of something label Nov 28, 2024
@evgeniiz321
Copy link
Contributor Author

@roman-khimov i would merge this PR, the test is valid and checks some interesting scenario. It doesn't validate #895, but still a good test case to have. For #895 we will create a new test.

Copy link
Member

@carpawell carpawell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree as long as it does not close the issue.

@roman-khimov roman-khimov removed the blocked Can't be done because of something label Nov 28, 2024
@roman-khimov roman-khimov merged commit 463f7d1 into master Nov 28, 2024
7 checks passed
@roman-khimov roman-khimov deleted the ezayats/replication-failure branch November 28, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants