New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Catastrophic backtracking regex condition (#64) #65

Merged

captainsafia merged 1 commit into nteract:master from tregoning:master

Jul 29, 2021

Contributor

tregoning commented Jul 18, 2021

Fix for: #64

All current tests pass with the suggested new regex + performance/crash issue is resolved.

Unfortunately I don't think it's possible to test for a regex ReDoS since obviously everything crashes when it's triggered.


           fix: Catastrophic backtracking regex condition (nteract#64)

b20bb18

captainsafia approved these changes

View reviewed changes

Member

captainsafia left a comment

This regex causes us a headache every now and then. May be time to consider a third-party package for this.

In any case, thanks for the bug report and the fix!

captainsafia merged commit fa8a84c into nteract:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet