Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#390 changed 'import tensorflow.keras' to 'import keras' #392

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

bking-astro
Copy link
Collaborator

linked to issue #390

fixing legacy usage of keras

@sahiljhawar
Copy link
Member

@bking-astro add import keras in training.py

@sahiljhawar
Copy link
Member

amazing, good ol' pymultinest installation error is back

change --preinstall to --auto-update
add asyncio options
@sahiljhawar
Copy link
Member

@mcoughlin any suggestions for pymultinest on ubuntu?

@mcoughlin
Copy link
Member

Not beyond raising an issue on their GitHub. Worked be great to drop it as a mandatory dependency

@sahiljhawar
Copy link
Member

This is not a pymultinest issue as far as I can see, it is due to pytest-asyncio. I am able to reproduce and mitigate this locally, but the solution is not working on Github Actions. Tried looking on bilby's Actions, their tests are passing.

@sahiljhawar sahiljhawar mentioned this pull request Feb 6, 2025
@sahiljhawar sahiljhawar merged commit ab8c52b into main Feb 6, 2025
12 of 17 checks passed
@sahiljhawar
Copy link
Member

I am merging this to reflect the keras changes, CI issues will be dealt later on, refer #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants