-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nidx node tests #2602
Merged
Merged
Nidx node tests #2602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javitonino
force-pushed
the
nidx_node_tests
branch
from
November 7, 2024 12:27
1ec4dc8
to
9f6e0e3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2602 +/- ##
==========================================
- Coverage 86.19% 86.15% -0.04%
==========================================
Files 376 376
Lines 23580 23580
==========================================
- Hits 20325 20316 -9
- Misses 3255 3264 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jotare
approved these changes
Nov 7, 2024
Co-authored-by: Joan Antoni RE <[email protected]>
javitonino
added a commit
that referenced
this pull request
Nov 7, 2024
javitonino
added a commit
that referenced
this pull request
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Settings changes
sqlx::test
s because they can create the db pool but don't have access to a db connection string. This way we have a single pool when running all components locally which is a better than starting 5 pools (per component).__
. This is to better support nested structs with fields with underscore in their names.Grpc changes
GrpcServer
struct.Test changes