Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hidden resource filter in catalog [sc-11549] #2828

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

javitonino
Copy link
Contributor

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.78%. Comparing base (67a6048) to head (2dd5fbf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2828      +/-   ##
==========================================
- Coverage   86.83%   86.78%   -0.05%     
==========================================
  Files         380      380              
  Lines       23872    23874       +2     
==========================================
- Hits        20730    20720      -10     
- Misses       3142     3154      +12     
Flag Coverage Δ
nucliadb 75.26% <100.00%> (-0.10%) ⬇️
nucliadb-ingest 40.95% <0.00%> (-0.01%) ⬇️
nucliadb-reader 42.73% <0.00%> (-0.01%) ⬇️
nucliadb-search 44.18% <50.00%> (-0.02%) ⬇️
nucliadb-standalone 47.36% <0.00%> (-0.01%) ⬇️
nucliadb-train 45.51% <0.00%> (-0.01%) ⬇️
nucliadb-writer 46.81% <0.00%> (+<0.01%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.78% <ø> (ø)
nucliadb_sdk 83.13% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino changed the title Fix hidden resource filter in catalog sc-11549 Fix hidden resource filter in catalog [sc-11549] Jan 30, 2025
@javitonino javitonino merged commit cdc7508 into main Jan 30, 2025
40 checks passed
@javitonino javitonino deleted the hidden_resources_catalog branch January 30, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants