Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphRAG: Better search for entities #2834

Merged
merged 3 commits into from
Feb 4, 2025
Merged

GraphRAG: Better search for entities #2834

merged 3 commits into from
Feb 4, 2025

Conversation

javitonino
Copy link
Contributor

Moves the logic to search for entities from graph strategy to nidx, so it can be done faster and in a single index request.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.76%. Comparing base (c09e5c2) to head (586805f).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...liadb/src/nucliadb/search/search/graph_strategy.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2834      +/-   ##
==========================================
- Coverage   86.87%   86.76%   -0.11%     
==========================================
  Files         380      380              
  Lines       23879    23868      -11     
==========================================
- Hits        20744    20710      -34     
- Misses       3135     3158      +23     
Flag Coverage Δ
nucliadb 75.22% <90.00%> (-0.14%) ⬇️
nucliadb-ingest 40.98% <20.00%> (+<0.01%) ⬆️
nucliadb-reader 42.72% <20.00%> (-0.01%) ⬇️
nucliadb-search 44.18% <20.00%> (+0.01%) ⬆️
nucliadb-standalone 47.36% <20.00%> (+0.01%) ⬆️
nucliadb-train 45.51% <20.00%> (+0.01%) ⬆️
nucliadb-writer 46.81% <20.00%> (+0.01%) ⬆️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_models 85.62% <ø> (-0.16%) ⬇️
nucliadb_sdk 83.13% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javitonino javitonino merged commit 9f994b6 into main Feb 4, 2025
40 checks passed
@javitonino javitonino deleted the graphrag_suggest branch February 4, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants