Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorset API improvements #2836

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Vectorset API improvements #2836

merged 6 commits into from
Feb 4, 2025

Conversation

jotare
Copy link
Contributor

@jotare jotare commented Feb 3, 2025

Description

Describe the proposed changes made in this PR.

How was this PR tested?

Describe how you tested this PR.

@jotare jotare requested a review from a team February 3, 2025 16:16
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 90.76923% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (84d4c14) to head (9d64562).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nucliadb/src/nucliadb/learning_proxy.py 25.00% 3 Missing ⚠️
nucliadb/src/nucliadb/writer/api/v1/vectorsets.py 95.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   86.78%   86.77%   -0.02%     
==========================================
  Files         380      379       -1     
  Lines       23879    23875       -4     
==========================================
- Hits        20724    20717       -7     
- Misses       3155     3158       +3     
Flag Coverage Δ
nucliadb 75.22% <87.69%> (-0.02%) ⬇️
nucliadb-ingest 40.96% <20.00%> (-0.01%) ⬇️
nucliadb-reader 42.70% <20.00%> (-0.01%) ⬇️
nucliadb-search 44.16% <20.00%> (-0.01%) ⬇️
nucliadb-standalone 47.34% <20.00%> (-0.01%) ⬇️
nucliadb-train 45.49% <20.00%> (-0.01%) ⬇️
nucliadb-writer 46.78% <41.53%> (-0.02%) ⬇️
nucliadb_dataset 55.45% <ø> (ø)
nucliadb_sdk 83.13% <ø> (ø)
nucliadb_telemetry 86.56% <ø> (ø)
nucliadb_utils 83.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotare jotare merged commit e38eedd into main Feb 4, 2025
40 checks passed
@jotare jotare deleted the vectorset-api-improvements branch February 4, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants