feat: add alternative nue.yaml config filename #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if even the site.yaml was also configurable. As an example, using the following command line option ( nue --config nue.yaml serve |
JensRoland
force-pushed
the
feat/alternative-config-filename
branch
from
c631c05 to
e067014
Compare
|
I have removed the multi-filename code as discussed in the issue: #407 This PR should be ready to merge |
|
wow! I like this. nice work. my only concern is how to keep the schema file up to date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have submitted a JSON Schema describing the Nue
site.yamlfile to schemastore.org in order to get editor support for the Nue config (autoexpand and validation).However, since thesite.yamlfilename is generic, it is not ideal for file matching (needed for convenient auto-detection of the schema).Thus, it would be nice to add an alternative filename,nue.yaml, which could be autodetected. I don't want to make a breaking change and propose changing it, but allowing both would work too.This PR extends Nue to support either filename.Update: The PR now simply adds a reference to the schema allowing editors to use it; and fixes a minor bug where
readDatawould fail on missing path instead of returning.Related: #407