Optimize startup #12
Open
Optimize startup #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug htat caused the process to hang, I narrowed it down to the pygame.init being called multiply tims. @nuke Bloodaxe if you don't like the pyCharm ide just leave out the .idea folder in the pull request merge. removing format changes
I did not want to maintain this as many many repeated lines, so I created a wrapper function for this. Not sure the multiline format that I use is the prettiest, but did this to make any future diff/merge easier.
Before: Initialising Planets: : complete. in 20.547 seconds. After: Initialising Planets: : complete. in 3.737 seconds.
|
Hmm some of the old formatting stuff sneaked in here, I will update shortly. There is a few blank lines with spaces, that my editor insist to remove. |
nukebloodaxe
reviewed
Dec 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason I forked this project in the first place was because I wanted to exercise a bit in speed-optimizing python code.
First i added some code to display the consumed time along with the "initializing .....:complete" messages.
Then I Found two places where the initialization could be quite a bit faster. Both related to the planet initialization.
Before:
Initialising Planets: : complete. in 20.547 seconds.
After:
Initialising Planets: : complete. in 3.737 seconds.
If you like this change please take it and use it, if not just reject it. I had my fun and got to sharpen a skill ;-)