✨(dimail) send pending mailboxes upon domain activation #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjeammet
force-pushed
the
mpj/dimail/enable-pending-mailboxes
branch
2 times, most recently
from
4e78755 to
f83a1f2
Compare
send creation requests to dimail for all pending mailboxes when domain goes from "pending" to "enabled".
mjeammet
force-pushed
the
mpj/dimail/enable-pending-mailboxes
branch
from
f83a1f2 to
4e40e96
Compare
Morendil
reviewed
Jan 16, 2025
| response.content.decode("utf-8").replace("'", '"') | ||
| ) | ||
| # fix format to have actual json | ||
| dimail_data = json.loads(response.content.decode("utf-8").replace("'", '"')) |
There was a problem hiding this comment.
Why not response.json() ? (Question applies not just to this line, but everywhere in the codebase where we have the above form…)
There was a problem hiding this comment.
because dimail's reponse used to not be a valid json.
But it might be fixed but invisible because of our mock ... I'm going to check it out
There was a problem hiding this comment.
Dimail's response seems to be a proper json now so I added it to fixtures and referenced it in all related tests
dimail's ok response upon mailbox creation is used in several tests. All those tests now reference proper response available in fixtures.
mjeammet
commented
Jan 16, 2025
| ## MAILBOXES | ||
|
|
||
|
|
||
| def response_mailbox_created(email_address): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
send creation requests to dimail for all pending mailboxes
when domain goes from "pending" to "enabled".
Proposal
Description...