-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add content on performance benchmarks. #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @khushi-411! Looks like a good start.
|
||
## Conclusion | ||
|
||
* These benchmarks are run with an Intel Core i7 processor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably belongs in the caption of the graph. With a bit more details about the exact CPU. For example:
$ cat /proc/cpuinfo | grep Intel
And then slightly reformat like: Intel i9-7920X @ 2.90GHz
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologizes, I will update that. Thanks!
|
||
* These codes are originally taken from [here](https://github.com/paugier/nbabel) | ||
* Benchmark code: [here](https://github.com/khushi-411/numpy-benchmarks/blob/0.3/python/benchmark-2.py) | ||
* Graph: [here](https://github.com/khushi-411/numpy-benchmarks/blob/0.3/python/plot-modified-1.py) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to your own repo is fine for now. We can make it a separate NumPy repo or put the scripts in an existing repo somewhere, when you are closer to done with this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure definitely, these are just sample codes. I feel that these need to be improved, and once it's finalized, we can create a repo or update somewhere in the existing repo as you'll wish. Thanks!
|
||
### NumPy | ||
|
||
NumPy is a most fundamental package for scientific computing in Python. The major advantage of using NumPy is these gives same computational speed as C and Fortran. Let's see our inplementation details: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking what should come next is indeed a comparison with C/C++ and Fortran, like this sentence says?
The accelerators can be a second part of the story.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text should explain that this is a numerical simulation of the N-body problem and giv ethe constraints of the problem
C/C++ and Fortran code simulations can be found in the original repo https://github.com/paugier/nbabel/
# NumPy Benchmarking | ||
|
||
|
||
![output-modify-2-new](https://user-images.githubusercontent.com/62256509/127653679-5151e22d-d141-4621-abb9-b3e6dd7988b7.jpg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to commit the figure in this PR. The place to put it is static/images/content_images/
This PR adds content on performance. Follows issue: #370
Please have a look. Thanks!
Rendered markdown link (for ease of readability): https://github.com/khushi-411/numpy.org/blob/master/content/en/benchmark.md
Future work which should be added here according to me are:
cc: @mattip