Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved visibility of unit test errors #1440

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Improved visibility of unit test errors #1440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 25 additions & 12 deletions cake/unit-testing.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,36 @@ public static class UnitTesting
var unitTests = FindUnitTestFiles(BuildSettings.UnitTests);

_context.Information($"Located {unitTests.Count} unit test assemblies.");
var errors = new List<string>();

foreach (var testPath in unitTests)
RunTest(testPath);
}
{
var testFile = testPath.GetFilename();
var containingDir = testPath.GetDirectory().GetDirectoryName();
var runtime = IsValidRuntime(containingDir) ? containingDir : null;

Banner.Display(runtime != null
? $"Running {testFile} under {runtime}"
: $"Running {testFile}");

private static void RunTest(FilePath testPath)
{
var testFile = testPath.GetFilename();
var containingDir = testPath.GetDirectory().GetDirectoryName();
var msg = "Running " + testFile;
if (IsValidRuntime(containingDir))
msg += " under " + containingDir;
var runner = BuildSettings.UnitTestRunner ?? new NUnitLiteRunner();
int rc = runner.Run(testPath);

Banner.Display(msg);
var name = runtime != null
? $"{testFile}({runtime})"
: testFile;
if (rc > 0)
errors.Add($"{name}: {rc} tests failed");
else if (rc < 0)
errors.Add($"{name} returned rc = {rc}");
}

var runner = BuildSettings.UnitTestRunner ?? new NUnitLiteRunner();
runner.Run(testPath);
if (unitTests.Count == 0)
_context.Warning("No unit tests were found");
else if (errors.Count > 0)
throw new Exception(
"One or more unit tests failed, breaking the build.\r\n"
+ errors.Aggregate((x, y) => x + "\r\n" + y) );

static bool IsValidRuntime(string text)
{
Expand Down