Drop agents for .NET 7.0 and .NET Core 3.1 #1603
Conversation
CharliePoole
requested review from
a team and
stevenaw
and removed request for
a team
| - name: 🛠️ Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: | | ||
| 3.1.x | ||
| 6.0.x | ||
| 7.0.x |
There was a problem hiding this comment.
Why are we adding the 7.0 runtime to remove support for it?
There was a problem hiding this comment.
A bit of a similar question from me @CharliePoole . I assume these are needed for tests?
There was a problem hiding this comment.
An earlier build failed because I removed it by mistake, so I added it back. Yes, we need both 3.1 and 7.0 for the test data assemblies, like mock-assembly.dll.
There was a problem hiding this comment.
Thanks @CharliePoole . LGTM, though I left a small question just for my own understanding.
| - name: 🛠️ Setup .NET | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: | | ||
| 3.1.x | ||
| 6.0.x | ||
| 7.0.x |
There was a problem hiding this comment.
A bit of a similar question from me @CharliePoole . I assume these are needed for tests?
|
The adapter runs under .net core 3.1. Not sure yet when we can step up that one. |
|
@OsirisTerje The adapter, however doesn't use agents. Even so, I'll take a look at the latest code to be sure before I merge this. |
|
@OsirisTerje I reviewed the code for the adapter and I see it references the engine package without specifying a version. The So... if the adapter has continued to build through all those changes, I would think we're OK. In this PR I have not changed the engine itself although the agents present in the package have changed. OTOH, I'm surprised if you are able to call .NET 8.0 dependencies from .NET Core 3.1. In retrospect, I guess I ought to know more about what you need from the engine. I'll go ahead and merge this because it seems that anything broken has been broken by the 3.19 release as well. Before we get to a release point, I think one of us should experiment by forcing the adapter to use the latest engine alpha build, so we can be know whether some further fix is needed. |
Fixes #1601
@nunit/engine-team I have enabled automatic assignment of reviews for this team. If I have done it right, only those who have expressed a willingness to review will be included. Let's see what happens when I push the button!
UPDATE: Github picked @stevenaw ! So far so good. :-)