This repository has been archived by the owner on Jan 8, 2023. It is now read-only.
Update nuget features and uwp template #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Realised that the change in #77 also needed to be made to the .pp file.
Trying to test this, I realised that the UWP .pp files aren't even distributed, so spent a good while trying to get that to work. Eventually I came across this issue: NuGet/Home#1980 - which seems to mean that this isn't currently possible with the project.json UWP uses. Gaah. Will set up an issue to track that.
Anyway, to avoid completely wasting my time, thought I'd also push some of the other issues I encountered on the way.
build.ps1needed updating as the nuget.exe path for NuGet 3 has changed - so the nuspec with thecontentFilesattribute couldn't be built. NuGet.config was added so we can pull in dev framework builds.