Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

Prepare for 3.6.1 release #93

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Prepare for 3.6.1 release #93

merged 1 commit into from
Mar 16, 2017

Conversation

ChrisMaddock
Copy link
Member

This is the release PR for 3.6.1. This replaces #90 - which was closed automatically when I renamed the branch.

@rprouse - There's a draft release in place. The only odd bit is that GitHub currently shows the git-tag and the draft release separately. I don't know if these will merge together automatically when the release is published, or if the release notes will need copying over.

Other than that, as far as I'm aware, the remaining things to do are:

  • Review this PR/release package
  • Make release public
  • Push to NuGet
  • Rebuild website
  • Merge back to master. (I'm happy to do this one!)

Let me know if I've missed anything, or if there's any more I can do! 😄

@ChrisMaddock ChrisMaddock requested a review from rprouse March 14, 2017 21:51
@ChrisMaddock
Copy link
Member Author

Note the master CI is currently failing at the packaging stage, as it takes the git-tag as the version. I kept this consistent with the other tags in this repo, using the format "v3.6.1" - but that isn't a valid NuGet version string.

The release package is built from the branch, so doesn't use the git-tag that's on the master. In future, perhaps we should tag as "3.6.1" without the "v"? That's how it is in the framework repository. Alternatively, we could adjust the Cake script to sanitise this.

Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Sorry I reviewed so late your time.

@ChrisMaddock
Copy link
Member Author

Thanks Rob.

The next steps are in your hands - I don't have the keys to upload to NuGet, or relaunch the website. If you can sort those two, I can merge back to master. 😄

@rprouse
Copy link
Member

rprouse commented Mar 16, 2017

I am a bit delayed on this. Sat down to do it tonight and my computer booted to updating windows. Now my computer isn't booting...

@rprouse
Copy link
Member

rprouse commented Mar 16, 2017

Well, windows update ended being a full OS reinstall. Working through it now, hopefully can test and release tomorrow.

@rprouse
Copy link
Member

rprouse commented Mar 16, 2017

Thanks for your help on this @ChrisMaddock. It has been released.

@rprouse rprouse merged commit a6118ed into master Mar 16, 2017
@rprouse rprouse deleted the release/3.6.1 branch March 16, 2017 20:18
@ChrisMaddock
Copy link
Member Author

Great, thanks @rprouse! I'll do the merge back to master tonight. 😄

@rprouse rprouse restored the release/3.6.1 branch April 3, 2017 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants