Fix incorrect spaces count of East Asian characters #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycs77
changed the title
xiCO2k
force-pushed
the
fix/east-asian-characters-width
branch
from
f2442e1 to
9386f72
Compare
xiCO2k
approved these changes
Jun 3, 2024
|
Looks good to me. cc @nunomaduro |
|
@xiCO2k can you fixes tests on main and rebase? |
|
Sure Will do it later today |
xiCO2k
force-pushed
the
fix/east-asian-characters-width
branch
from
9386f72 to
c8a50c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #185
Using
mb_strwidth()to replacemb_strlen()to fix the incorrect spaces count of East Asian characters.