Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to add additional nuocollector scripts. #36

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

butson
Copy link
Contributor

@butson butson commented Jun 29, 2022

It would be useful to be able to add additional configuration to nuocollector besides the insights output plugin. We want to integrate with sumologic remotely and influx/insights locally.

@sivanov-nuodb
Copy link
Contributor

sivanov-nuodb commented Jun 30, 2022

I'm a bit confused about why we need to support arbitrary nuocollector plugins in the insights chart.
This is already supported by the admin and database charts. Please see nuocollector.plugins.admin and nuocollector.plugins.database variables. Is there a reason not to declare the Sumologic output plugin when deploying the admin and the database?

@butson
Copy link
Contributor Author

butson commented Jul 1, 2022 via email

@sivanov-nuodb
Copy link
Contributor

If you put it in nuocollector then you can’t deploy and undeploy without upgrading the chart which then will stop and restart the engine.

AFIAK the admin and database charts also just register ConfigMap resources for the customer plugins which doesn't require a restart of the engines. A rolling upgrade is only required if you enable the previously disabled nuocollector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants