Create deployment framework for Terraform tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a framework for deploying NuoDB Control Plane instances in various configurations, and consolidates the CircleCI jobs that were previously known as integration_test and e2e_test. The integration_test job was relying on the test-helper.tgz package that was published into the nuodb/nuodb-cp-releases repo. This has been replaced by KWOK, which is a tool for creating K8s clusters for test purposes. Unlike EnvTest, KWOK includes the controller-manager, which enables garbage collection and scheduling of workloads like Deployments and StatefulSets. This allows the simulated reconciliation logic that was previously being used to be replaced by real reconciliation logic being performed by an instance of the NuoDB Operator. This change also decouples various aspects of the test environment that were previously conflated together based on the E2E_TEST environment variable. POD_SCHEDULING_ENABLED is used to skip tests that would take too long in a true end-to-end configuration, or inject configuration to speed up the test. WEBHOOKS_ENABLED is used to skip tests that exercise invalid configurations, which may be rejected by the server in a way that prevents us from achieving the desired Terraform test coverage.
adriansuarez
commented
Apr 8, 2024
There was a problem hiding this comment.
It might be better to review this in split-mode (click the gear at the top of the page), since a lot of the content is just being replaced instead of changed.
sivanov-nuodb
approved these changes
Apr 9, 2024
| @@ -21,8 +22,53 @@ import ( | |||
| "github.com/stretchr/testify/require" | |||
| ) | |||
|
|
|||
| func IsE2E() bool { | |||
| return os.Getenv("E2E_TEST") == "true" | |||
There was a problem hiding this comment.
We'll need to change how nuodb-dbaas-deploy executes the TF plugin tests.
There was a problem hiding this comment.
Thanks for the reminder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a framework for deploying NuoDB Control Plane instances in various configurations, and consolidates the CircleCI jobs that were previously known as integration_test and e2e_test.
The integration_test job was relying on the test-helper.tgz package that was published into the nuodb/nuodb-cp-releases repo. This has been replaced by KWOK, which is a tool for creating K8s clusters for test purposes. Unlike EnvTest, KWOK includes the controller-manager, which enables garbage collection and scheduling of workloads like Deployments and StatefulSets. This allows the simulated reconciliation logic that was previously being used to be replaced by real reconciliation logic being performed by an instance of the NuoDB Operator.
This change also decouples various aspects of the test environment that were previously conflated together based on the E2E_TEST environment variable. POD_SCHEDULING_ENABLED is used to skip tests that would take too long in a true end-to-end configuration, or inject configuration to speed up the test. WEBHOOKS_ENABLED is used to skip tests that exercise invalid configurations, which may be rejected by the server in a way that prevents us from achieving the desired Terraform test coverage.