Commulative update (Pass options, php7 and more) #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dates from xls files created with LibreOffice were turned into invalid values, so here's a fix for that
Dates from xls files created with LibreOffice were turned into invalid values, so here's a fix for that
Fixed LibreOffice date import
Dates from xls files created with LibreOffice were turned into invalid values, so here's a fix for that
Added a fix for recognising dates in XLS files created by LibreOffice
Another try at committing correctly
Warning: include(SpreadsheetReader/XLSX.php): failed to open stream: No such file or directory in /Users/username/Sites/sitename/lib/Varien/Autoload.php on line 93
…ksheet was inaccessible Original bug report of XLSX bug: nuovo#59 (comment)
Original bug report of XLSX bug: nuovo#59 (comment)
# Conflicts: # SpreadsheetReader_XLSX.php
- Implemented SeekableIterator. Thanks to [paales](https://github.com/paales) for suggestion ([Issue nuovo#54](nuovo#54) and [Pull request nuovo#55](nuovo#55)). - Fixed a bug in CSV and ODS reading where reading position 0 multiple times in a row would result in internal pointer being advanced and reading the next line. (E.g. reading row #0 three times would result in rows #0, nuovo#1, and nuovo#2.). This could have happened on multiple calls to `current()` while in #0 position, or calls to `seek(0)` and `current()`.
… spreadsheetreader (again) Updated from https://github.com/nuovo/spreadsheet-reader/ Original bug report of XLSX bug: nuovo#59 (comment)
Get sheet id with any format string wrapper around it eg box/spout writes xslx where sheet id is formatted as rIdSheet{n} not rId{0}
…lue written 'General'. After fix in cell we will see real value.
Merge libreoffice fixes
…ndolg/spreadsheet-reader into aandolg-fixed_read_for_general_format
# Conflicts: # SpreadsheetReader_XLSX.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Got the last changes from community and added passing options