[billieboy7} iP #519
Open
[billieboy7} iP #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamz903
reviewed
Sep 5, 2023
src/main/java/Task/Task.java
Outdated
| return (isDone ? "X" : " "); // mark done task with X | ||
| } | ||
|
|
||
| public void taskDone(boolean status) { |
There was a problem hiding this comment.
Minor coding violation! Boolean variables/methods should be named to sound like booleans, and setter methods for boolean variables should be in the following form instead:
Suggested change
| public void taskDone(boolean status) { | |
| public void setDone(boolean isDone) { |
jamz903
reviewed
Sep 5, 2023
| } | ||
|
|
||
| @Override | ||
| public boolean end() { |
There was a problem hiding this comment.
Suggested change
| public boolean end() { | |
| public boolean getEnd() { |
src/main/java/Command/Command.java
Outdated
|
|
||
| public void execute(TaskList taskList, UI ui, Storage storage) throws DukeException {} | ||
|
|
||
| public boolean end() { |
There was a problem hiding this comment.
Suggested change
| public boolean end() { | |
| public boolean getEnd() { |
There are no checks currently on how the user input is being handled within the program itself. Using assert statements checks whether the input is being handled properly within the programme and whether each method is working in the way it is intended to. Assert statements are preferred because their less disruptive.
Lack of standardisation of package names threw errors. execute method did not return anything which the gui package could use. Standardised names of the package imports were from. execute method returns string to display on gui.
Insert assert statements
Merge branch 'master' into branch-A-CodeQuality
…ng methods Parser class initially had 2 different operations - 1) To decide the type of command to be returned 2) Check for the validity of the formatting of the command once the type of command to be returned was determined. Abstracting the second operation(validation check) allows the parse method to be simpler and look neater.
Users cant change the description without deleting the task. Introduced a new functionality that allows for the updating of the tasks without deleting the older tasks. Makes it easier, convenient and faster for the updating of task descriptions especially when there are multiple changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duke - Task Tracker
Liberate your mind from the burden of remembering tasks. Duke offers:
speedSPEEDSo what do you have to do :
Awesome Features
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: