-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tijngsheng] ip #526
base: master
Are you sure you want to change the base?
[tijngsheng] ip #526
Conversation
change-readme
add-duke-level-7
add-duke-level-8
add-a-moreoop
add-a-gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how most of the coding standards and coding quality standards are met, good job for the IP so far!
src/main/java/Parser/Parser.java
Outdated
@@ -0,0 +1,29 @@ | |||
package Parser; | |||
|
|||
import Command.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should wildcard imports be used? Maybe it is better to list them out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think * is better as I am importing almost every command in that package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HMMM actually now that I saw this " Rationale: Importing classes explicitly gives an excellent documentation value for the class at hand and makes the class easier to comprehend and maintain. Appropriate tools should be used in order to always keep the import list minimal and up to date. IDE's can be configured to do this easily." in the style guide, I am feeling conflicted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can IDE be configured to do it though?
add-a-javadoc
add-duke-level-10
add-duke-level-10
add-duke-level-10
add-a-varargs
add-a-codequality
add-a-assertions
applied SLAP (and other abstraction mechanisms) to shorten methods e.g., extract some code blocks into separate methods. You may ignore this suggestion if you think a longer method is justified in a particular case. Avoid committing binary files (e.g., *.class, *.jar, *.exe) or third- party library files in to the repo. Removed Sono.zip. Add improvements to exception handling.
add-bcd-extension
add-week-six
improve-application
update-readme-ug
Duke project
Hello from
Project Description
This is my project, created from a template for a greenfield Java project.
It's named after the Java mascot Duke.
This project is a Java application that aims to provide a user-friendly task management system. It allows users to manage their tasks efficiently and keep track of their schedules.
Features
Installation Option 1
Go to tjingsheng ip releases
Get Java: Ensure you have a functioning version of Java.
Copy the JAR File: Copy the JAR file you want to run into an empty folder.
Open a Command Window: Open a command prompt (Windows) or terminal (macOS/Linux) in the same folder where you copied the JAR file.
Run the Command: Use the following command to run the JAR file:
Enjoy: Duke is very fun.
Installation Option 2
Todo List
CryProject Sample