[mamayuan] ip #534

mamayuan · 2023-09-03T13:27:35Z

DukePro - Task Manager 📖

“Your mind is for having ideas, not holding them.” – David Allen

DaDaYuan frees your mind of having to remember things you need to do. It's:

text-based
~~complex~~ easy to learn
FAST SUPER FAST to use 🚀

All you need to do is:

Download it from here
Double-click it.
Add your tasks.
Let it manage your tasks for you 😉

And it is ~~expensive~~ FREE! 🎉

Features:

Managing tasks
Managing deadlines
Reminders

If you're a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

…evel-7 # Conflicts: # src/main/java/duke/io/Loader.java # src/main/java/duke/io/Saver.java

jibtaf

Looks good to me, although there may be some style errors. Perhaps adding javadoc and header comments for public methods will make your code more clear and easier to understand. Also, according to the Git conventions, you should use "Add", "Settle", "Finalise" instead of "Adds", "Settles", and "Finalises". Overall, well done! 👍

jibtaf · 2023-09-07T12:12:00Z

src/main/java/duke/Duke.java

+package duke;
+
+import duke.exceptions.FileIoException;
+import duke.tasks.*;


Should the classes imported be explicitly listed out?

jibtaf · 2023-09-07T12:14:44Z

src/main/java/duke/Duke.java

+import duke.exceptions.UnknownCommandException;
+
+
+import java.util.ArrayList;


I think import java.* should be before import duke.*, according to the checkStyle function.

jibtaf · 2023-09-07T12:15:07Z

src/main/java/duke/Duke.java

+import duke.exceptions.EmptyDescriptionException;
+import duke.exceptions.UnknownCommandException;
+
+


Perhaps one blank line is enough?

ChangruHenryQian

Good job!

ChangruHenryQian · 2023-09-10T07:18:04Z

src/main/java/duke/Duke.java

+                        System.out.println("Got it. I've added this task:");
+                        System.out.println("  " + tasks.getTask(tasks.getNumberOfTasks() - 1));
+                        System.out.println("Now you have " + tasks.getNumberOfTasks() + " task(s) in the list.");


Should Ui class do the printing part?

ChangruHenryQian · 2023-09-10T07:19:52Z

src/main/java/duke/tasks/TaskType.java

+public enum TaskType {
+    TODO, EVENT, DEADLINE
+}


I like your implementation of the enum class for task types.

ChangruHenryQian · 2023-09-10T07:20:40Z

src/main/java/duke/exceptions/ErrorMessages.java

@@ -0,0 +1,31 @@
+package duke.exceptions;
+
+public class ErrorMessages {


Great implementation on ErrorMessage class.

ChangruHenryQian · 2023-09-10T07:22:05Z

src/main/java/duke/io/Storage.java

+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.Files;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Scanner;
+
+import duke.tasks.Task;
+import duke.tasks.Todo;
+import duke.tasks.Event;
+import duke.tasks.Deadline;
+import duke.tasks.TaskList;
+import duke.exceptions.UnknownCommandException;
+import duke.exceptions.FileIoException;
+import duke.exceptions.ErrorMessages;


I enjoy your clean separation and ordering of the import statements.

The Duke application lacks a user interface and a main entry point for users to interact with. To make the Duke application user-friendly and navigable, we need a proper user interface and an entry point to launch the application. Implement the MainWindow class to act as the controller for the main application window. Add the DialogBox custom control to display dialogues for the user and Duke with associated images. Introduce the Launcher class as the application's entry point. Using JavaFX, we can ensure a consistent and efficient user interface. The DialogBox custom control allows us to encapsulate dialogue functionalities, ensuring code reusability and organization. The Launcher acts as a clear entry point for the application, keeping the initialization process straightforward. Added Javadoc comments to the newly created classes for better documentation and clarity.

Test

damithc and others added 12 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

Rename, Greet, Exit

5c08f4a

Rename of file

a3d3ef3

Merge remote-tracking branch 'origin/add-gradle-support'

c920eb5

Correct missing colon

e749d9b

Echo

5313878

Add, List

8fbe6a7

Mark as Done

190c265

ToDos, Events, Deadlines

c5b73f0

Handle Errors

54a8f46

Delete

0e1f882

mamayuan changed the title ~~Up to Level-6~~ [mamayuan] Up to Level-6 Sep 3, 2023

mamayuan changed the title ~~[mamayuan] Up to Level-6~~ [mamayuan] ip Sep 3, 2023

mamayuan added 13 commits September 4, 2023 20:47

Packages inner classes

ffc3bea

Reorganise packages

4254a9d

Reorganises packages again

293be32

Fix bugs up to level-5

69d7ab7

Merges branches

e6dac5a

fixes bugs up to level-6

8427364

Adds Store

1b7b325

Merge branch 'master' of https://github.com/mamayuan/ip into branch-L…

52cfcb3

…evel-7 # Conflicts: # src/main/java/duke/io/Loader.java # src/main/java/duke/io/Saver.java

Settles conflicts

1d6bdf7

Settles conflicts

27bdd65

Finalises level-7

b8c497f

Adds TimeParser.java

c56540d

Adds OOP and Level-9

fb71673

jibtaf reviewed Sep 7, 2023

View reviewed changes

Fixes bugs

1470ddd

ChangruHenryQian reviewed Sep 10, 2023

View reviewed changes

mamayuan and others added 30 commits September 16, 2023 16:53

Fix bugs on datetime

a039171

Add A-Varargs

cbb15f7

Add java docs

dfe455d

Add java docs

b0089fb

Add java doc

9a4e302

Add Javadoc

0e87ad4

Add HelpCommand

5a4a11d

Add images for GUI

2e9145c

Fix code quality

2940d85

Add Java docs

42913a5

Finalise GUI

755cb74

Remove unnecessary attributes

3ec55e3

Add A-Assertions

92da170

Add Junit test files

fdd8f6b

Fix Checkstyle

385fe40

Add User Guide

87c9caa

Add image for Readme

99fc457

Fix Javfx version

16844bd

Gradle

2f09a11

Fix bugs for Event storage

89a669e

Fix TimeParser bugs

481b874

Test

596d0d7

Merge pull request #2 from mamayuan/Test

ee2a89a

Test

Fix bugs

64cc76e

Merge branch 'master' of https://github.com/mamayuan/ip

bb74eb5

Add Ui.png to readme

b4d354d

Fix UserGuide

9356d80

Minor changes

b8634a9

Add link to release

97fa977

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[mamayuan] ip #534

[mamayuan] ip #534

mamayuan commented Sep 3, 2023 •

edited

Loading

jibtaf left a comment •

edited

Loading

jibtaf Sep 7, 2023

jibtaf Sep 7, 2023

jibtaf Sep 7, 2023

ChangruHenryQian left a comment

ChangruHenryQian Sep 10, 2023

ChangruHenryQian Sep 10, 2023

ChangruHenryQian Sep 10, 2023

ChangruHenryQian Sep 10, 2023

		import duke.exceptions.UnknownCommandException;


		import java.util.ArrayList;

		import duke.exceptions.EmptyDescriptionException;
		import duke.exceptions.UnknownCommandException;

		@@ -0,0 +1,31 @@
		package duke.exceptions;

		public class ErrorMessages {

[mamayuan] ip #534

Are you sure you want to change the base?

[mamayuan] ip #534

Conversation

mamayuan commented Sep 3, 2023 • edited Loading

DukePro - Task Manager 📖

Features:

jibtaf left a comment • edited Loading

Choose a reason for hiding this comment

jibtaf Sep 7, 2023

Choose a reason for hiding this comment

jibtaf Sep 7, 2023

Choose a reason for hiding this comment

jibtaf Sep 7, 2023

Choose a reason for hiding this comment

ChangruHenryQian left a comment

Choose a reason for hiding this comment

ChangruHenryQian Sep 10, 2023

Choose a reason for hiding this comment

ChangruHenryQian Sep 10, 2023

Choose a reason for hiding this comment

ChangruHenryQian Sep 10, 2023

Choose a reason for hiding this comment

ChangruHenryQian Sep 10, 2023

Choose a reason for hiding this comment

mamayuan commented Sep 3, 2023 •

edited

Loading

jibtaf left a comment •

edited

Loading