[Qin Nanxin] iP #572

InfiBeyond · 2023-09-07T14:40:10Z

Duke Max

“Hi, I am Duke Max. Your personal task management companion."

Duke Max[ frees your mind of having to remember things you need to do. It's,

text-based
easy to learn
FAST SUPER FAST to use

All you need to do is,

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines (coming soon)
Reminders (coming soon)

If you Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

(a) Changed chatbot name form Duke to Edna (b) Implement an initial skeletal version

Improve the skeletal version of Edna so that it echos commands entered by the user, and exits when the user types the command bye.

Add the ability to store whatever text entered by the user and display them back to the user when requested.

(a) Create Task class. (b) Add the ability to mark tasks as done. (c) Add the ability to change the status back to not done.

Add support for tracking three types of tasks: ToDos: tasks without any date/time attached to it e.g., visit new theme park Deadlines: tasks that need to be done before a specific date/time e.g., submit report by 11/10/2019 5pm Events: tasks that start at a specific date/time and ends at a specific date/time e.g., (a) team project meeting 2/10/2019 2-4pm (b) orientation week 4/10/2019 to 11/10/2019 * Fixed Level 3 error for mixing up "X" and " " for marked and unmarked tasks.

Use the input/output redirection technique to semi-automate the testing of Duke.

Teach the chatbot to deal with errors such as incorrect inputs entered by the user. Use Exceptions to handle errors Define a class DukeException to represent exceptions specific to Duke.

Add support for deleting tasks from the list.

Previously missed this file during git push.

- Unable figure out why my computer cannot open the previous files - Attempt to clone work from GitHub didn't work Level 0. Rename, Greet, Exit (a) Rename chatbot to "Edna-Duke". (b) Implement an initial skeletal version of the it that simply greets the user and exits.

Improve the skeletal version of Duke so that it echos commands entered by the user, and exits when the user types the command bye.

Add the ability to store whatever text entered by the user and display them back to the user when requested.

Add the ability to mark tasks as done. Optionally, add the ability to change the status back to not done.

Add support for tracking three types of tasks: - ToDos: tasks without any date/time attached to it e.g., visit new theme park - Deadlines: tasks that need to be done before a specific date/time e.g., submit report by 11/10/2019 5pm - Events: tasks that start at a specific date/time and ends at a specific date/time e.g., (a) team project meeting 2/10/2019 2-4pm (b) orientation week 4/10/2019 to 11/10/2019

Teach the chatbot to deal with errors such as incorrect inputs entered by the user.

Add support for deleting tasks from the list.

mounilsankar · 2023-09-08T11:49:48Z

src/main/java/Deadline.java

Overall good job! Good use of abstraction using the Task class! However, it might be a better idea to have even more abstraction through the addition of a UI class that handles all the printing and a TaskList class that handles the list of Tasks.

mounilsankar · 2023-09-08T11:51:42Z

src/main/java/Duke.java

The indentation for the case blocks inside the switch statement within the try block does not follow the coding standard

AlainS87 · 2023-09-08T16:02:36Z

src/main/java/Duke.java

+
+    public static void exit() {
+        System.out.println("Bye. Hope to see you again soon!");
+        System.out.println(partition);
    }
 }


Indentation & Formatting:

The code seems to be properly indented, which makes it easier to read.
The consistent use of brackets {} and their placement adheres to the Java coding conventions.
Variable Naming:

Names like input, eventCommand, and ddlCommand are meaningful, but some variables like ddl could have a more descriptive name.
Variables should be named in a manner that makes their purpose clear. For instance, ddl might be better named as deadlineDetails or similar.
sc has not been defined in the given snippet, so it's unclear what it represents. If it's a Scanner object, a more intuitive name like scanner might be more appropriate.

AlainS87 · 2023-09-08T16:02:59Z

src/main/java/ToDo.java

+    public String getStatus() {
+        return "[To-Do]" + super.getStatus();
+    }
+}


This program has only finished Week1-2 tasks, more OOP should be added

andrefoo · 2023-09-10T08:28:20Z

src/main/java/Duke.java

@@ -26,6 +26,10 @@ public static void main(String[] args) {
                        int unmarkItem = sc.nextInt();
                        taskList.get(unmarkItem - 1).markUndone();
                        break;
+                    case "delete":


Consider making inputs case-insensitive!

This way, if I requested to add a todo writing: tOdO it would still add the task into the list.
Try using 'String' 's equalsIgnoreCase() method compares two strings, ignoring lower case and upper case differences.

andrefoo

LGTM, some minor amendments needed that's all.

andrefoo · 2023-09-13T07:32:23Z

src/main/java/Duke.java

 public class Duke {
+    public static String partition = "------------------------------------------------------------";


Consider changing 'partition' to a final variable as it does not change, as well as fully capitalising the variable name to be 'PARTITION'

Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when the chatbot starts up.

* branch-Level-7: [Level 7. Save] Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when the chatbot starts up.

Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

* branch-Level-8: [Level 8. Dates and Times Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

* branch-Level-8: [Level 8. Dates and Times] Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

Kevin-Liusx · 2023-09-20T03:17:26Z

src/main/java/Duke.java

+            } 
+
+            catch (DukeException e) {
+                System.out.println(e.getMessage());


I think your method is too long here. Maybe try to create some other methods?😎

* branch-Level-10: Add MainWindow.java [Level 10. GUI] Add a GUI to the chatbot. Use the JavaFX technology to implement the GUI. [Level 10. GUI] Initialize a GUI to the chatbot.

This bundles JavaFX with the JAR file. This makes sure that the application will work in computers that don't have JavaFX installed. Generating a new JAR file improves the user inclusivity.

Use assert feature (not JUnit assertions) to document important assumptions that should hold at various points in the code.

Use checkStyle to detect coding style violations. Update file to ix styling issue and improve user readability.

[A-Assertions]

* 'master' of https://github.com/InfiBeyond/ip: [A-Assertions]

[A-CheckStyle] Improve Code Quality

* 'master' of https://github.com/InfiBeyond/ip: [A-CheckStyle]

Add the ability to recognize and deal with duplicate items. Warn users when attempting to add a new task with the same task description with existing task.

* branch-C-DetectDuplicates: [C-DetectDuplicates]

* branch-A-BetterGui: Fix GUI for display text by changing height and width. # Conflicts: # src/main/java/duke/tasks/Task.java

* 'master' of https://github.com/InfiBeyond/ip: Update README.md

Fix height of dialog box to custom user input and bot reply length.

Add bot greeting on initialization and disable input after exit command.

Add updated UI screenshot to repo

More wholesome testing for Parser and Todo

Remove .class files

damithc and others added 18 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

[Level 0. Rename, Greet, Exit]

abfac81

(a) Changed chatbot name form Duke to Edna (b) Implement an initial skeletal version

[Level 1. Echo]

517a3a2

Improve the skeletal version of Edna so that it echos commands entered by the user, and exits when the user types the command bye.

[Level 2. Add, List]

5130bfd

Add the ability to store whatever text entered by the user and display them back to the user when requested.

[Level 3. Mark as Done]

5823330

(a) Create Task class. (b) Add the ability to mark tasks as done. (c) Add the ability to change the status back to not done.

[Automated Text UI Testing]

5f799dd

Use the input/output redirection technique to semi-automate the testing of Duke.

[Level 5. Handle Errors]

227c818

Teach the chatbot to deal with errors such as incorrect inputs entered by the user. Use Exceptions to handle errors Define a class DukeException to represent exceptions specific to Duke.

[Level 6. Delete]

c8a51aa

Add support for deleting tasks from the list.

Add DukeException class

b60464f

Previously missed this file during git push.

[Level 1. Echo]

cb37643

Improve the skeletal version of Duke so that it echos commands entered by the user, and exits when the user types the command bye.

[Level 2. Add, List]

06d749e

Add the ability to store whatever text entered by the user and display them back to the user when requested.

[Level 3. Mark as Done]

ccefdd8

Add the ability to mark tasks as done. Optionally, add the ability to change the status back to not done.

[Level 5. Handle Errors]

f6fa252

Teach the chatbot to deal with errors such as incorrect inputs entered by the user.

[Level 6. Delete]

268ecd1

Add support for deleting tasks from the list.

mounilsankar reviewed Sep 8, 2023

View reviewed changes

AlainS87 reviewed Sep 8, 2023

View reviewed changes

andrefoo reviewed Sep 10, 2023

View reviewed changes

andrefoo reviewed Sep 13, 2023

View reviewed changes

InfiBeyond added 6 commits September 15, 2023 18:03

[Level 7. Save]

ec71f5a

Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when the chatbot starts up.

Merge branch 'branch-Level-7'

2832520

* branch-Level-7: [Level 7. Save] Save the tasks in the hard disk automatically whenever the task list changes. Load the data from the hard disk when the chatbot starts up.

[Level 8. Dates and Times

8e0a3da

Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

[Level 8. Dates and Times]

bc20f51

Teach the chatbot how to understand dates and times. For example, if the command is deadline return book /by 2/12/2019 1800, the chatbot should understand 2/12/2019 1800 as 2nd of December 2019, 6pm, instead of treating it as just a String.

Kevin-Liusx reviewed Sep 20, 2023

View reviewed changes

InfiBeyond and others added 30 commits September 28, 2023 15:09

Merge branch 'branch-Level-10'

64cd33a

* branch-Level-10: Add MainWindow.java [Level 10. GUI] Add a GUI to the chatbot. Use the JavaFX technology to implement the GUI. [Level 10. GUI] Initialize a GUI to the chatbot.

Generate a new JAR file using Gradle

677a0a3

This bundles JavaFX with the JAR file. This makes sure that the application will work in computers that don't have JavaFX installed. Generating a new JAR file improves the user inclusivity.

[A-Assertions]

e9c434c

Use assert feature (not JUnit assertions) to document important assumptions that should hold at various points in the code.

[A-CheckStyle]

c9b3825

Use checkStyle to detect coding style violations. Update file to ix styling issue and improve user readability.

Merge pull request #2 from InfiBeyond/branch-A-Assertions

e62e810

[A-Assertions]

Merge branch 'master' of https://github.com/InfiBeyond/ip

9c23bc9

* 'master' of https://github.com/InfiBeyond/ip: [A-Assertions]

Merge pull request #3 from InfiBeyond/branch-A-CodeQuality

f1ca54a

[A-CheckStyle] Improve Code Quality

Merge branch 'master' of https://github.com/InfiBeyond/ip

59dedbd

* 'master' of https://github.com/InfiBeyond/ip: [A-CheckStyle]

[C-DetectDuplicates]

7c5fc1f

Add the ability to recognize and deal with duplicate items. Warn users when attempting to add a new task with the same task description with existing task.

Merge branch 'branch-C-DetectDuplicates'

8cc478f

* branch-C-DetectDuplicates: [C-DetectDuplicates]

Fix GUI for display text by changing height and width.

69a2e5d

Merge branch 'branch-A-BetterGui'

96b6642

* branch-A-BetterGui: Fix GUI for display text by changing height and width. # Conflicts: # src/main/java/duke/tasks/Task.java

Add Ui.png

17e9d8b

Update README.md

066511a

Update README.md

34a161e

Merge branch 'master' of https://github.com/InfiBeyond/ip

22fc82a

* 'master' of https://github.com/InfiBeyond/ip: Update README.md

Update GUI

91503fa

Fix height of dialog box to custom user input and bot reply length.

Update GUI

77e2a1d

Add bot greeting on initialization and disable input after exit command.

Fix missing Ui.png

47711eb

Add updated UI screenshot to repo

Update UI.png location

ca6addc

Fix styling errors

618da5b

Update README.md

f7d2b25

Update README.md

6182e16

Update README.md

ad511a3

Update README.md

a87b8a8

Update README.md

c77c2bb

Improve JUnit Testing

27af30c

More wholesome testing for Parser and Todo

Update Jar file

55a69f3

Update credits for code Reuse

699769d

Remove .class files

Update credits for code reuse

722c222

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Qin Nanxin] iP #572

[Qin Nanxin] iP #572

InfiBeyond commented Sep 7, 2023 •

edited

Loading

mounilsankar Sep 8, 2023

mounilsankar Sep 8, 2023

AlainS87 Sep 8, 2023

AlainS87 Sep 8, 2023

andrefoo Sep 10, 2023 •

edited

Loading

andrefoo left a comment

andrefoo Sep 13, 2023

Kevin-Liusx Sep 20, 2023

		public class Duke {
		public static String partition = "------------------------------------------------------------";

[Qin Nanxin] iP #572

Are you sure you want to change the base?

[Qin Nanxin] iP #572

Conversation

InfiBeyond commented Sep 7, 2023 • edited Loading

Duke Max

mounilsankar Sep 8, 2023

Choose a reason for hiding this comment

mounilsankar Sep 8, 2023

Choose a reason for hiding this comment

AlainS87 Sep 8, 2023

Choose a reason for hiding this comment

AlainS87 Sep 8, 2023

Choose a reason for hiding this comment

andrefoo Sep 10, 2023 • edited Loading

Choose a reason for hiding this comment

andrefoo left a comment

Choose a reason for hiding this comment

andrefoo Sep 13, 2023

Choose a reason for hiding this comment

Kevin-Liusx Sep 20, 2023

Choose a reason for hiding this comment

InfiBeyond commented Sep 7, 2023 •

edited

Loading

andrefoo Sep 10, 2023 •

edited

Loading