Skip to content

Commit

Permalink
Merge pull request #260 from lunaroddity/branch-personal-info
Browse files Browse the repository at this point in the history
Update YingXuan's PPP
  • Loading branch information
Nauxe authored Nov 13, 2023
2 parents badd7b9 + b38f7ca commit 9773783
Showing 1 changed file with 12 additions and 19 deletions.
31 changes: 12 additions & 19 deletions docs/team/lunaroddity.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,50 +16,43 @@ I have contributed to the project in the following ways:
You can find a summary of all my code contributions in this [RepoSense link](https://nus-cs2103-ay2324s1.github.io/tp-dashboard/?search=&sort=groupTitle&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code&since=2023-09-22&tabOpen=true&tabType=authorship&tabAuthor=lunaroddity&tabRepo=AY2324S1-CS2103T-T10-4%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=&authorshipIsBinaryFileTypeChecked=false&authorshipIsIgnoredFilesChecked=false)!
### Viewing a person's contact
* Implemented the abstract `ViewCommand` class to allow for further extension of the view command
* Implemented the concrete `ViewPersonCommand` class to allow users to easily view one person’s contact at a time
* Created efficient and effective test code for the `ViewPersonCommand` class to ensure it functions according to
specifications
* Implemented the concrete `ViewPersonCommand` class to allow users to easily view one person’s contact at a time
### Adding an internship to a company contact
* Implemented the `AddInternshipCommand` class to add an internship to a specified company
* Created efficient and effective test code for the `AddInternshipCommand`class to ensure it functions according to
specifications
* Implemented the `AddInternshipCommand` class to add an internship to a specified company
### Editing an existing internship in a company contact
* Implemented the `EditInternshipCommand` class to keep information on internships up-to-date
* Created efficient and effective test code for the `EditInternshipCommand`class to ensure it functions according to
specifications
* Implemented the `EditInternshipCommand` class to keep information on internships up-to-date
* Improved the abstraction and code quality of the `EditCommandParser`
* Created efficient and effective test code for the class I have implemented to ensure they function according to
specifications

## Documentation
### User Guide (UG)
1. Added documentation for the view person, add internship and edit internship commands
2. Added a prefix summary for easy reference to the constraints associated with each prefix
3. Polished the language of the UG to be more enthusiastic and user-centric
4. Standardised the formatting used throughout the UG to improve consistency and clarity
3. Polished the language of the entire UG to be more enthusiastic and user-centric
4. Standardised the formatting used throughout the entire UG to improve consistency and clarity
5. Revised the UG to include more callouts to enhance its visual appeal and readability

### Developer Guide (DG)
Added implementation details and UML diagrams for:
* View Person
* Add Internship
* Edit Internship
Added implementation details and UML diagrams for ViewPersonCommand

## Team-based tasks
* Attended weekly meetings and contributed to the discussion of the implementation of features and other future plans actively
* Came up with over 20 user stories

## Reviewing and mentoring
Reviewed PRs thoroughly and left members constructive feedback to help improve overall code quality and organisation
Reviewed 23 PRs and left members constructive feedback to help improve overall code quality and organisation
* Examples
* [#94](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/94)
* [#118](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/118)
* [#132](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/132)
* [#196](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/196)
* [#202](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/202)
* [#202](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/202) (though it was closed, my review contributed to the changes seen in [#203](https://github.com/AY2324S1-CS2103T-T10-4/tp/pull/203))

## Beyond the project team
1. Reviewed the UG and v1.3 .jar release as part of the Practical Exam Dry Run and provided constructive feedback by opening issues under the name Tester D [CS2103T-T14-1](https://github.com/AY2324S1-CS2103T-T14-1/tp)
1. Reviewed the UG and v1.3 `.jar` release as part of the Practical Exam Dry Run and provided constructive feedback by opening issues under the name Tester D [CS2103T-T14-1](https://github.com/AY2324S1-CS2103T-T14-1/tp)
2. Organised an informal class-wide peer review for the class CS2103T-T10
3. Reviewed the UG, DG and v1.4 .jar release for my classmates and provided constructive feedback by opening issues
3. Reviewed the UG, DG and v1.4 .jar release for my classmates and provided constructive feedback on Google Docs
* [CS2103T-T10-1](https://github.com/AY2324S1-CS2103T-T10-1/tp)
* [CS2103T-T10-2](https://github.com/AY2324S1-CS2103T-T10-2/tp)
4. Opened several issues on the CS2103T forum and shared solutions to aforementioned issues
Expand Down

0 comments on commit 9773783

Please sign in to comment.