-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-F08-4] NUSearch #113
Open
frrrrry
wants to merge
535
commits into
nus-cs2103-AY2324S1:master
Choose a base branch
from
AY2324S1-CS2103T-F08-0:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-F08-4] NUSearch #113
frrrrry
wants to merge
535
commits into
nus-cs2103-AY2324S1:master
from
AY2324S1-CS2103T-F08-0:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Parser testcases
Update RoleContainsKeywordsPredicate
Add list command test cases and fix some bugs
Add testcases for SampleDataUtil
Update testcases 1
Update testcases 1 but better
AddressBookParser used to use a very lengthy switch/case statement to decide which command word was said. This can be shortened by using a map of Strings to CheckedFunctions (functional interfaces that behave like Functions but can throw an error). While this doesn't eliminate the complexity of checking, it does allow for autocomplete to be implemented easier with a unified list of command words, with not much additional cost to current implementations of parsing methods. Let's change it to this equally complex but more easily extensible method of implementation!
Let's add the autocomplete feature that allows users to cycle through command suggestions.
Let's update the changed files to comply with the checkstyle specifications.
Fix bug related to tutorial
Fix some minor errors in UG
Update fry's ppp
Fix bugs in UG and Add Command usage message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NUSearch helps NUS students have quick access to vital information about professors, teaching assistants, or fellow students enrolled in specific courses or tutorials. It is optimized for CLI users so that frequent searches can be done faster by typing in commands.