Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F08-4] NUSearch #113

Open
wants to merge 535 commits into
base: master
Choose a base branch
from

Conversation

frrrrry
Copy link

@frrrrry frrrrry commented Sep 22, 2023

NUSearch helps NUS students have quick access to vital information about professors, teaching assistants, or fellow students enrolled in specific courses or tutorials. It is optimized for CLI users so that frequent searches can be done faster by typing in commands.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Attention: 114 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (b0d4d31) 77.40%.

❗ Current head b0d4d31 differs from pull request most recent head b34778f. Consider uploading reports for the commit b34778f to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/ui/CommandBox.java 0.00% 32 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 25 Missing ⚠️
.../seedu/address/logic/parser/EditCommandParser.java 0.00% 23 Missing ⚠️
...in/java/seedu/address/logic/parser/ParserUtil.java 91.86% 3 Missing and 4 partials ⚠️
.../java/seedu/address/storage/JsonAdaptedPerson.java 88.23% 1 Missing and 5 partials ⚠️
...a/seedu/address/model/person/UniquePersonList.java 66.66% 2 Missing and 2 partials ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 3 Missing ⚠️
...du/address/logic/commands/FindTutorialCommand.java 81.25% 3 Missing ⚠️
...java/seedu/address/logic/commands/EditCommand.java 94.59% 1 Missing and 1 partial ⚠️
...a/seedu/address/logic/parser/AddCommandParser.java 81.81% 1 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #113      +/-   ##
============================================
+ Coverage     75.26%   77.40%   +2.14%     
- Complexity      419      579     +160     
============================================
  Files            71       89      +18     
  Lines          1338     1894     +556     
  Branches        126      183      +57     
============================================
+ Hits           1007     1466     +459     
- Misses          301      386      +85     
- Partials         30       42      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lawruixi and others added 29 commits October 29, 2023 19:58
Add list command test cases and fix some bugs
AddressBookParser used to use a very lengthy switch/case statement to
decide which command word was said.

This can be shortened by using a map of Strings to CheckedFunctions
(functional interfaces that behave like Functions but can throw an
error). While this doesn't eliminate the complexity of checking, it
does allow for autocomplete to be implemented easier with a unified
list of command words, with not much additional cost to current
implementations of parsing methods.

Let's change it to this equally complex but more easily extensible
method of implementation!
Let's add the autocomplete feature that allows users to cycle through
command suggestions.
Let's update the changed files to comply with the checkstyle
specifications.
frrrrry and others added 30 commits November 13, 2023 20:14
Add Edit, Delete & Unfav, edit Fav
Fix bugs in UG and Add Command usage message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants