Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-T11-2] InterviewHub #46

Open
wants to merge 687 commits into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Sep 18, 2023

InterviewHub is targetted at Tech/Engineering hiring managers with coding experience who prefer CLI interfaces and needs logical organization for their potential hires.
Provides users quick access to the entire pool of interviewees, their contacts and their resumes. Also allows the users to take notes during the interview and to also leave a review/rating of the potential hire for future internal usage

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 444 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (531fffb) 67.77%.

❗ Current head 531fffb differs from pull request most recent head 2e26504. Consider uploading reports for the commit 2e26504 to get more accurate results

Files Patch % Lines
...u/address/logic/commands/EditInterviewCommand.java 0.00% 76 Missing ⚠️
...du/address/logic/commands/AddInterviewCommand.java 31.57% 22 Missing and 4 partials ⚠️
src/main/java/seedu/address/model/AddressBook.java 71.42% 15 Missing and 9 partials ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 0.00% 24 Missing ⚠️
...dress/logic/parser/EditInterviewCommandParser.java 0.00% 23 Missing ⚠️
...u/address/model/interview/UniqueInterviewList.java 59.64% 14 Missing and 9 partials ⚠️
...va/seedu/address/storage/JsonAdaptedInterview.java 56.75% 8 Missing and 8 partials ⚠️
...address/logic/commands/DeleteInterviewCommand.java 25.00% 13 Missing and 2 partials ⚠️
...in/java/seedu/address/logic/parser/TimeParser.java 67.39% 10 Missing and 5 partials ⚠️
...main/java/seedu/address/ui/ApplicantListPanel.java 0.00% 13 Missing ⚠️
... and 35 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #46      +/-   ##
============================================
- Coverage     75.26%   67.77%   -7.50%     
- Complexity      419      641     +222     
============================================
  Files            71      111      +40     
  Lines          1338     2296     +958     
  Branches        126      263     +137     
============================================
+ Hits           1007     1556     +549     
- Misses          301      630     +329     
- Partials         30      110      +80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JasonLCY-Temp and others added 29 commits November 7, 2023 14:04
Update UG for 'add-i' 'edit-i' and 'delete-i' commands
Fix the ped bug and ppp bug
- Update accepted date with time formats for parseDate
- Update accepted date formats for parseDate
- Update the return type of parseDate
- Method was moved out of TimeParser, hence DG needs to be
updated to reflect this change
- findFreeTime has since been moved from TimeParser
and hence the DG needs to be updated to reflect this change
- Method has since been deleted from TimeParser, hence
DG needs to be updated to reflect this change
DG needs to be updated to reflect this change
- Method has since been deleted from TimeParser, hence
DG needs to be updated to reflect this change
- Removed design considerations from methods that
have since been moved/removed from TimeParser
Moved the list of "Accepted time formats" to the "Notes about command
format" section near the top.
Edited the description of acceptable inputs to "Job Role" in add-i and
edit-i to specify that special characters are accepted as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants