[CS2103T-T12-1] NpcTrack #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #55 +/- ##
============================================
+ Coverage 70.45% 72.23% +1.78%
- Complexity 679 719 +40
============================================
Files 109 111 +2
Lines 2427 2536 +109
Branches 314 317 +3
============================================
+ Hits 1710 1832 +122
+ Misses 621 599 -22
- Partials 96 105 +9 ☔ View full report in Codecov by Sentry. |
Chrainx
pushed a commit
to Chrainx/tp
that referenced
this pull request
Oct 17, 2023
Add question to FAQ
…into proto-aiken-13-branch-a-v1.3-markAttendanceUpdate
in Attendance.java To ensure better rigour in ensuring the attendance handled is valid, the constructor must be changed to update the participation accordingly if the student is absent for that day. Moreover, test coverage has been added to the attendance, and attendance marking classes.
Fix participation valid range
Fix group attendance marking bug
Assigning Large Numbers with `assign` and others
Optional.ofNullable() to be used where null is allowed.
Make previous command tracking more extensible
of participation points The participation command points have been capped at 1000, so the testcases need to be adjusted accordingly.
of participation points The participation command points have been capped at 1000, so the testcases need to be adjusted accordingly.
Add deassign individual command
TypicalPersons.java and SampleDataUtil.java Changed files in accordance to et-irl's feedback in the PR review comments.
Update user guide
Rectified typos in the UG and re-added definitions for Command Status.
Refactor UG and DG
Fix UG and DG
Removed Extraneous Space
Fix DG Activity Diagram
to status == null Removed the incredibly problematic status == null functionality in MarkAttendanceParser.java.
Refactor MarkAttendanceParser to remove references to status == null
Update proto-aiken-13.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NpcTrack helps Teaching Assistants to find and organise their students' contacts in a easy and swift manner, making it easier for them to reach out and communicate their students