Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-W17-1]: Flagship #64

Open
wants to merge 476 commits into
base: master
Choose a base branch
from

Conversation

javinchua
Copy link

Flagship helps students store contacts to find internships. It is optimized for CLI users so that frequent tasks can be done faster by typing in commands.

@javinchua javinchua changed the title CS2103-W17-1]: Flagship [CS2103-W17-1]: Flagship Sep 19, 2023
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Attention: 128 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (a895900) 80.64%.

❗ Current head a895900 differs from pull request most recent head ad08695. Consider uploading reports for the commit ad08695 to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/InternshipMainApp.java 0.00% 22 Missing ⚠️
src/main/java/seedu/address/ui/InternshipCard.java 0.00% 13 Missing ⚠️
...ain/java/seedu/address/ui/InternshipListPanel.java 0.00% 12 Missing ⚠️
...eedu/address/logic/parser/FilterCommandParser.java 89.81% 5 Missing and 6 partials ⚠️
...in/java/seedu/address/ui/InternshipMainWindow.java 0.00% 11 Missing ⚠️
...a/seedu/address/ui/PredicateComparatorDisplay.java 0.00% 8 Missing ⚠️
...va/seedu/address/model/InternshipModelManager.java 90.78% 7 Missing ⚠️
...va/seedu/address/logic/InternshipLogicManager.java 50.00% 6 Missing ⚠️
...va/seedu/address/logic/commands/ModifyCommand.java 96.39% 2 Missing and 2 partials ⚠️
...ava/seedu/address/model/internship/Internship.java 92.45% 0 Missing and 4 partials ⚠️
... and 14 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #64      +/-   ##
============================================
+ Coverage     75.26%   80.64%   +5.38%     
- Complexity      419      595     +176     
============================================
  Files            71       80       +9     
  Lines          1338     1881     +543     
  Branches        126      200      +74     
============================================
+ Hits           1007     1517     +510     
- Misses          301      321      +20     
- Partials         30       43      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuxunn pushed a commit to yuxunn/tp that referenced this pull request Oct 5, 2023
Chrainx pushed a commit to Chrainx/tp that referenced this pull request Oct 25, 2023
…testing

Fix unit testing for add customer command
jinyang628 and others added 26 commits November 2, 2023 14:35
Currently, the UG for filter command does not follow the format of the rest of the UG and is not very comprehensive.

Improving the readability of the UG as well as the overall harmony is essential in guiding users in using Flagship in the most efficient manner.

Let's improve the UG by giving more examples of the different formats of the filter command and ensure it is up-to-date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants