[CS2103T-W11-1] HRMate #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #76 +/- ##
============================================
+ Coverage 75.26% 84.40% +9.13%
- Complexity 419 1000 +581
============================================
Files 71 146 +75
Lines 1338 2904 +1566
Branches 126 289 +163
============================================
+ Hits 1007 2451 +1444
- Misses 301 395 +94
- Partials 30 58 +28 ☔ View full report in Codecov by Sentry. |
yuxunn
added a commit
to yuxunn/tp
that referenced
this pull request
Oct 20, 2023
Revert "Merge pull request nus-cs2103-AY2324S1#76 from yuxunn/delete_commands"
…n of feature freeze" This reverts commit 34ae093. Reason for revert: Clarified with Prof and received approval for change
…-addressBookParser-caseInsensitive Revert "Make the command word case-insensitive"
AddLeaveCommandParser::parse is modified to use if-else instead of stream operations, as Stream::map is unable to handle ParseException. All changes related to Messages::format(Leave) have been reverted to avoid violating feature flaw. Note that this means that all leaves printed in CommandResult will not feature the Description field. Other changes include renaming the variables containing the error messages - Messages.java from the master branch was used instead to remove all modified error messages from this branch.
Commit d447735 had changes that improved index parsing, which would allow it to distinguish between an integer overflow and a non-numeric index. These changes have been reverted, along with their test cases, as the overflow scenario would have thrown a different error message, a violation of the feature freeze.
…into branch-FixAddLeaveNotProcessed
Leave::belongsTo previously used equals, which is an issue as there is no guarantee that the employee field in the leave contains the same instance as the employee list. By changing it to use ComparablePerson::isSamePerson instead, only the name will be compared, thus fixing the bug. Test cases were added for Leave and EditCommandIntegrationTest to guarantee that the code produces the desired behaviour.
This reverts commit fd45514.
DeleteCommand::execute was affected by the same Leave::belongsTo bug as EditCommand::execute. These test cases will ensure that a similar bug can be detected in future. Additionally, assertCommandFailure will now check that the LeavesBook and filteredLeaveList remain unmodified.
Clear command now clears both the employee list and the leave list.
Update content of PPP
…into branch-DevGuide
…into branch-RyanPPP
update ppp
Update Ryan's PPP
Branch dg manual testing
Update nanxin ppp
removed unneeded lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HRMate aims to streamline HR processes by offering an intuitive, CLI-based contact management system with specialised functionalities for HR tasks. This enables easy access to employee records and facilitates the tracking of performance evaluations and interview schedules.