Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103-W11-4] LinkTree #8

Open
wants to merge 491 commits into
base: master
Choose a base branch
from

Conversation

StevenLiudw
Copy link

LinkTree is the top contact solution for software professionals. Using our unique tag-based system, access contacts by roles and responsibilities instantly. With LinkTree, swiftly connect with the right stakeholder, ensuring smooth project execution and superior collaboration.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Attention: 429 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (ce87412) 68.36%.

❗ Current head ce87412 differs from pull request most recent head 4259b4d. Consider uploading reports for the commit 4259b4d to get more accurate results

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 134 Missing ⚠️
src/main/java/seedu/address/ui/TeamCard.java 0.00% 43 Missing ⚠️
.../java/seedu/address/model/team/UniqueTeamList.java 56.79% 27 Missing and 8 partials ⚠️
...rc/main/java/seedu/address/ui/LinkTreeDisplay.java 0.00% 22 Missing ⚠️
...va/seedu/address/logic/commands/AddDevCommand.java 0.00% 19 Missing ⚠️
...eedu/address/logic/parser/AddDevCommandParser.java 0.00% 16 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 6.66% 14 Missing ⚠️
src/main/java/seedu/address/ui/TeamListPanel.java 0.00% 14 Missing ⚠️
...in/java/seedu/address/ui/TeamStructureDisplay.java 0.00% 14 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 11 Missing ⚠️
... and 33 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master       #8      +/-   ##
============================================
- Coverage     75.26%   68.36%   -6.90%     
- Complexity      419      686     +267     
============================================
  Files            71      111      +40     
  Lines          1338     2415    +1077     
  Branches        126      242     +116     
============================================
+ Hits           1007     1651     +644     
- Misses          301      690     +389     
- Partials         30       74      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erohsikivar and others added 28 commits November 3, 2023 01:43
Update UG for 'list' and 'listteam'
This commit addresses several bugs and issues in the FindTeamCommand and FindTeamLeaderCommand classes.

These fixes improve the reliability and accuracy of both FindTeamCommand and FindTeamLeaderCommand, ensuring that they work as intended and provide better user feedback when encountering issues. Unit tests have also been updated to cover these scenarios to prevent regressions in the future.
Fix FindTeamCommand and FindTeamLeaderCommand Bugs
erohsikivar and others added 30 commits November 14, 2023 01:33
…h-TestingAndDocumentation

# Conflicts:
#	docs/DeveloperGuide.md
PPP is still not finished yet.

A updated PPP can better reflect ones contribution.

Let's put more information about what I have contributed.

Clear contribution is good for the team management.
Add instruction for manual testing into DG
Current DG for edit and tree commands are not implemented.

A detailed DG can help future application development.

Let's update the DG to have all the relevant information for those
commands.

Detailed information can help future developers extend current
implementation.
Some of the coding style is not up to standard.

A unified coding style shall make this project like as if it is
implemented by one person.

Let's modify the code to have a standard style.

It will also help others understand the code better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants