Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2103T-F12-1] Uno FAS #84

Open
wants to merge 612 commits into
base: master
Choose a base branch
from

Conversation

nikele2001
Copy link

Uno FAS functions as a digital address book suited to the needs of financial advisors. It allows them to track, update, and manage their clients’ information efficiently. This is facilitated through the use of a command line interface for efficient and effective querying and modifying of clients’ data.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 177 lines in your changes are missing coverage. Please review.

Comparison is base (517b785) 75.26% compared to head (35569bb) 77.70%.

Files Patch % Lines
src/main/java/seedu/address/ui/MainWindow.java 0.00% 34 Missing ⚠️
src/main/java/seedu/address/ui/OverrideWindow.java 0.00% 31 Missing ⚠️
src/main/java/seedu/address/ui/ClearWindow.java 0.00% 26 Missing ⚠️
src/main/java/seedu/address/ui/PersonCard.java 0.00% 14 Missing ⚠️
.../java/seedu/address/model/util/SampleDataUtil.java 25.00% 12 Missing ⚠️
...in/java/seedu/address/ui/AppointmentListPanel.java 0.00% 12 Missing ⚠️
...rc/main/java/seedu/address/ui/AppointmentCard.java 0.00% 8 Missing ⚠️
src/main/java/seedu/address/MainApp.java 0.00% 7 Missing ⚠️
.../seedu/address/logic/commands/ScheduleCommand.java 84.37% 1 Missing and 4 partials ⚠️
...c/main/java/seedu/address/model/person/Person.java 90.24% 1 Missing and 3 partials ⚠️
... and 9 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #84      +/-   ##
============================================
+ Coverage     75.26%   77.70%   +2.44%     
- Complexity      419      713     +294     
============================================
  Files            71      103      +32     
  Lines          1338     2202     +864     
  Branches        126      224      +98     
============================================
+ Hits           1007     1711     +704     
- Misses          301      439     +138     
- Partials         30       52      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Chrainx pushed a commit to Chrainx/tp that referenced this pull request Oct 26, 2023
AlyssaPng and others added 28 commits November 10, 2023 15:43
Refactoring of code was done for comparator and
sortCommandParser. if else block in sortCommandParser
was also changed to a switch block to support future
expansion of sorting functions.

Moreover, some DG diagrams were altered and defensive
code was added to sortCommand classes.
Fix typos, improve readability and update Ui class diagram
Add DG use cases and minor changes
Fix invalid handling of data file upon application launch and minor c…
Kb-Tay and others added 30 commits November 14, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants