Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113T-T10-4] MindMyMoney #10

Open
wants to merge 700 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
700 commits
Select commit Hold shift + click to select a range
fdac841
Merge pull request #167 from khseah/kitHan-PPP
khseah Apr 6, 2022
3ff0fcf
Update DG
khseah55 Apr 6, 2022
e38f14a
Merge pull request #168 from khseah/kitHan-PPP
khseah Apr 6, 2022
f77529c
Update AboutUs Portfolio link
khseah55 Apr 6, 2022
72d17df
Merge pull request #169 from khseah/kitHan-PPP
khseah Apr 6, 2022
611e752
del cmd
SeanHoWB Apr 6, 2022
7eed2d4
update cmd
SeanHoWB Apr 6, 2022
c3c2e6a
Merge pull request #170 from SeanHoWB/Sean-Tests
SeanHoWB Apr 6, 2022
6644c47
Sean-PPP
SeanHoWB Apr 7, 2022
88cfcbe
Merge pull request #171 from SeanHoWB/Sean-PPP
SeanHoWB Apr 7, 2022
22c5876
Sean-PPP fixes
SeanHoWB Apr 7, 2022
77ac1e0
Sean-PPP fixes
SeanHoWB Apr 7, 2022
0790f9a
Merge pull request #172 from SeanHoWB/Sean-PPP
SeanHoWB Apr 7, 2022
7246438
Sean-PPP pic changes
SeanHoWB Apr 7, 2022
d2f8a44
Merge pull request #173 from SeanHoWB/Sean-PPP
SeanHoWB Apr 7, 2022
62f1f78
DG edits
SeanHoWB Apr 8, 2022
f25c6a9
DG edits
SeanHoWB Apr 8, 2022
5d4960a
Merge pull request #174 from SeanHoWB/Sean-DG_edits
SeanHoWB Apr 9, 2022
a6dfe65
Add Storage and Command class diagrams
Apr 9, 2022
ed9afd3
Merge branch 'master' into Branch-Add_DG
Apr 9, 2022
0182680
Fix coding standards
Apr 9, 2022
ebe295b
formatted the print to screens to 2dp
SeanHoWB Apr 9, 2022
9d2c1df
fixes
SeanHoWB Apr 9, 2022
e481b5b
Fix comments
Apr 9, 2022
326cac7
remove unecessary imports
Apr 9, 2022
7021769
Merge pull request #175 from limjierui/Branch-Add_DG
limjierui Apr 9, 2022
3aefe4f
fixes pt 2
SeanHoWB Apr 9, 2022
40ad536
Merge pull request #182 from SeanHoWB/Sean-Bug-Fixes
SeanHoWB Apr 9, 2022
95e6e28
Remove redundant images
khseah55 Apr 9, 2022
d8233ee
Update .gitignore to ignore data.txt
khseah55 Apr 9, 2022
dfc8c2e
Update AboutUs
khseah55 Apr 9, 2022
4df94fa
Add List Command portion of DG
khseah55 Apr 9, 2022
54cb78e
Update current UML diagrams to have background
khseah55 Apr 9, 2022
fb85704
Merge pull request #190 from khseah/kitHan-ListPortionOfDG
khseah Apr 9, 2022
d3a28fe
Update DG content page
khseah55 Apr 9, 2022
7ec915b
Merge pull request #191 from khseah/kitHan-ListPortionOfDG
khseah Apr 9, 2022
694096a
Update List Command design considerations
khseah55 Apr 9, 2022
7365659
Merge pull request #192 from khseah/kitHan-ListPortionOfDG
khseah Apr 9, 2022
604988e
Add limjierui PPP
Apr 9, 2022
12e998f
Merge pull request #193 from limjierui/Branch-AddPPP
limjierui Apr 9, 2022
3a1c79c
Update AddCommandSequence, AddExpenditureCommandSequenceDiagram, Comm…
GlendonNotGlen Apr 10, 2022
4d3b1f6
Merge pull request #194 from GlendonNotGlen/master
GlendonNotGlen Apr 10, 2022
e451658
Remove optional parameters and return values for neater sequence diag…
GlendonNotGlen Apr 10, 2022
ed29c2a
Remove activation bar for calculate command sequence diagram
GlendonNotGlen Apr 10, 2022
1bdae3a
Update sequence diagram to conform to UML standards
GlendonNotGlen Apr 10, 2022
ebb541e
Change to add credit card sequence diagram
GlendonNotGlen Apr 10, 2022
769f927
refactor checks to addcommandinputttest
SeanHoWB Apr 10, 2022
6642868
refactor checks to addcommandinputttest remove ugly files
SeanHoWB Apr 10, 2022
0fc39c3
fixes
SeanHoWB Apr 10, 2022
9af67a2
fixes
SeanHoWB Apr 10, 2022
45e7924
Merge pull request #196 from SeanHoWB/Sean-Bug-Fixes
SeanHoWB Apr 10, 2022
9eba7d4
Update sequence diagram to match refactored code
GlendonNotGlen Apr 10, 2022
ed747cf
Merge branch 'master' into master
GlendonNotGlen Apr 10, 2022
e91d3fe
Merge pull request #1 from AY2122S2-CS2113T-T10-4/master
GlendonNotGlen Apr 10, 2022
3263f11
Update add credit card and add income sequence diagrams
GlendonNotGlen Apr 10, 2022
92f3849
Merge pull request #197 from GlendonNotGlen/master
GlendonNotGlen Apr 10, 2022
7eecd33
Add Delete Command section into DG
GlendonNotGlen Apr 10, 2022
ed5fe98
Merge pull request #198 from GlendonNotGlen/master
GlendonNotGlen Apr 10, 2022
fbee545
Update Sequence Diagrams
GlendonNotGlen Apr 10, 2022
c4cc185
Update add command sequence diagram
GlendonNotGlen Apr 10, 2022
560325e
Refactor Sequence diagram code
GlendonNotGlen Apr 10, 2022
1c60d4a
Merge pull request #199 from GlendonNotGlen/master
GlendonNotGlen Apr 10, 2022
47f19a5
Enhance list command in UG.
Apr 10, 2022
23288f3
Remove commented out code
Apr 10, 2022
7d60ce6
Fix coding standard.
Apr 10, 2022
301bd26
Fix comments
Apr 10, 2022
d412c68
Fix minor date input
Apr 10, 2022
a960d1c
Merge pull request #200 from limjierui/Branch-Improve_UG
limjierui Apr 10, 2022
97ec792
check if cc name in list
SeanHoWB Apr 10, 2022
b3d5a08
check if cc name in list
SeanHoWB Apr 10, 2022
2c731f1
Refine UG
khseah55 Apr 10, 2022
11a29cb
Update data.txt
SeanHoWB Apr 10, 2022
59a8de7
Update DG with Update Command and update Update Expenditure command
GlendonNotGlen Apr 10, 2022
4251c41
Update code for coding standards
GlendonNotGlen Apr 10, 2022
4349b0c
Updated Content Table for Update Command
GlendonNotGlen Apr 10, 2022
6c5c760
Update docs/DeveloperGuide.md
GlendonNotGlen Apr 10, 2022
01a0850
Update docs/DeveloperGuide.md
GlendonNotGlen Apr 10, 2022
8416e09
Merge pull request #202 from GlendonNotGlen/branch-Glendon-DG_UpdateC…
GlendonNotGlen Apr 10, 2022
d34c966
Update AddCommandInputTests.java
SeanHoWB Apr 10, 2022
45d5625
Merge pull request #201 from SeanHoWB/Sean-Bug-Fixes
SeanHoWB Apr 10, 2022
e2f27d9
data
SeanHoWB Apr 10, 2022
9e912b1
Merge branch 'master' of https://github.com/SeanHoWB/tp
SeanHoWB Apr 10, 2022
4df80a8
Add load/store descriptions in DG
Apr 10, 2022
d93ff00
Add links to load/store in DG content page
danbaterisna Apr 10, 2022
78db59f
Merge branch 'master' into add-load-store-DG
danbaterisna Apr 10, 2022
baf0506
Update load/store diagrams
Apr 10, 2022
1aaeb5c
Merge branch 'add-load-store-DG' of github.com-danbaterisna:danbateri…
Apr 10, 2022
a79e747
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
f3b6e7a
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
32c3e18
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
aeae6ec
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
3819725
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
0ad988c
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
82e837e
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
b8e66ac
Update docs/puml/DeserializeListSequenceDiagram.puml
limjierui Apr 11, 2022
5cb6f80
Update docs/puml/SerializeListSequenceDiagram.puml
limjierui Apr 11, 2022
cfbe10b
Update docs/puml/SavingSequenceDiagram.puml
limjierui Apr 11, 2022
1fc68ea
Update docs/puml/LoadingSequenceDiagram.puml
limjierui Apr 11, 2022
96ab55d
Update docs/puml/DeserializeListSequenceDiagram.puml
limjierui Apr 11, 2022
6be11d7
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
c4ae21d
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
46228f1
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
da102a3
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
af7c72a
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
ef7d0bf
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
c9b19d3
Update docs/puml/LoadingSequenceDiagram.puml
limjierui Apr 11, 2022
4a914df
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
81dfa8c
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
0e65a0a
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
8f5be3e
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
2500d5b
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
f712f77
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
c50ce63
Update docs/puml/SavingSequenceDiagram.puml
limjierui Apr 11, 2022
2646631
Update docs/DeveloperGuide.md
limjierui Apr 11, 2022
eff592d
Update docs/puml/SerializeListSequenceDiagram.puml
limjierui Apr 11, 2022
f7455d0
Merge pull request #203 from danbaterisna/add-load-store-DG
limjierui Apr 11, 2022
6049a1f
Add initial instructions for manual testing
Apr 11, 2022
6a87524
fixed credit card limit bugs
SeanHoWB Apr 11, 2022
1288368
Merge branch 'master' into add-testing-instructions
Apr 11, 2022
d0c7319
Update ListExpenditure portion of DG
khseah55 Apr 11, 2022
9c66d12
fixed credit card limit UG
SeanHoWB Apr 11, 2022
29e3db5
Merge branch 'master' into kitHan-UGTouchUp
khseah55 Apr 11, 2022
5ef1c1d
Merge pull request #207 from khseah/kitHan-UGTouchUp
khseah Apr 11, 2022
a6135a7
fixed credit card limit UG
SeanHoWB Apr 11, 2022
48528fa
Proofread DG
GlendonNotGlen Apr 11, 2022
3617390
Merge pull request #208 from GlendonNotGlen/branch-Glendon-DG_Update
GlendonNotGlen Apr 11, 2022
cf6845b
Update sequence diagrams
GlendonNotGlen Apr 11, 2022
85f218e
Merge pull request #210 from GlendonNotGlen/branch-Glendon-DG_Update
GlendonNotGlen Apr 11, 2022
7cb5404
Refactor code and bug fix sequence diagrams
GlendonNotGlen Apr 11, 2022
90a09a6
Merge pull request #211 from GlendonNotGlen/master
GlendonNotGlen Apr 11, 2022
1c2aae1
ppp rename
SeanHoWB Apr 11, 2022
3d091cb
Add more instructions for manual testing
Apr 11, 2022
02f541b
fixes to trailing whitespaces
SeanHoWB Apr 11, 2022
5e66c05
merging conf
SeanHoWB Apr 11, 2022
aee29d0
Standardise border and arrow colour for diagrams in DG
Apr 11, 2022
0ce3726
Merge branch 'master' into Branch-Fix_DG
Apr 11, 2022
a2b874c
Merge pull request #214 from limjierui/Branch-Fix_DG
limjierui Apr 11, 2022
306dd65
Add description of save file format to UG
Apr 11, 2022
b7f2a84
Update Glendon PPP
GlendonNotGlen Apr 11, 2022
f80b1f6
Merge branch 'master' into branch-Update-PPP
GlendonNotGlen Apr 11, 2022
c3f2d94
Merge pull request #2 from AY2122S2-CS2113T-T10-4/branch-Update-PPP
GlendonNotGlen Apr 11, 2022
652d92a
Merge pull request #215 from AY2122S2-CS2113T-T10-4/branch-Update-PPP
GlendonNotGlen Apr 11, 2022
2a6d866
Resolve comments on testing instructions
Apr 11, 2022
8368030
Fix DG review comments
Apr 11, 2022
eabe212
fixed cashback too many dp
SeanHoWB Apr 11, 2022
77bdb76
fixed cashback too many dp fixes
SeanHoWB Apr 11, 2022
eb401c8
Merge pull request #216 from limjierui/Branch-Edit_PPP
limjierui Apr 11, 2022
42b663d
Update docs/DeveloperGuide.md
SeanHoWB Apr 11, 2022
2804e67
Merge branch 'master' into Sean-Bug-Fixes
SeanHoWB Apr 11, 2022
56f9d2a
format fixes
SeanHoWB Apr 11, 2022
6ca48c9
Merge branch 'Sean-Bug-Fixes' of https://github.com/SeanHoWB/tp
SeanHoWB Apr 11, 2022
3464788
Merge branch 'AY2122S2-CS2113T-T10-4:master' into master
GlendonNotGlen Apr 11, 2022
e353f71
Update Glendon PPP
GlendonNotGlen Apr 11, 2022
d5cb5fe
Merge pull request #206 from SeanHoWB/Sean-Bug-Fixes
SeanHoWB Apr 11, 2022
e95f52d
Merge pull request #217 from GlendonNotGlen/master
GlendonNotGlen Apr 11, 2022
17b23b9
Add Dan PPP
Apr 11, 2022
44fa2f4
Fix PPP to be within 2 page limit
Apr 11, 2022
63ddbfa
Merge pull request #218 from limjierui/Branch-FixPPPToBeWithinLimit
limjierui Apr 11, 2022
dd08b2d
Merge branch 'master' into dan-ug-ppp
danbaterisna Apr 11, 2022
fa448e6
Trim PPP to conform with page limit
khseah55 Apr 11, 2022
bcf7e6f
Merge branch 'master' into kitHan-TrimPPP
khseah55 Apr 11, 2022
058e900
shorten PPP Sean
SeanHoWB Apr 11, 2022
76a7461
Trim PPP further
khseah55 Apr 11, 2022
5b2131e
Merge pull request #221 from SeanHoWB/Sean-PPP
SeanHoWB Apr 11, 2022
3d04734
Merge pull request #219 from danbaterisna/dan-ug-ppp
SeanHoWB Apr 11, 2022
2c0d1cf
Merge branch 'master' into kitHan-TrimPPP
khseah55 Apr 11, 2022
11e7948
Merge pull request #220 from khseah/kitHan-TrimPPP
khseah Apr 11, 2022
ab37db7
shorten PPP Sean furhter
SeanHoWB Apr 11, 2022
57a0486
Cut PPP word count
Apr 11, 2022
423fc0d
Merge pull request #223 from limjierui/Branch-FurtherCutPPP
limjierui Apr 11, 2022
de12501
Merge pull request #222 from SeanHoWB/Sean-PPP
SeanHoWB Apr 11, 2022
2f28022
shorten PPP Sean furhterer
SeanHoWB Apr 11, 2022
da046af
Merge pull request #224 from SeanHoWB/Sean-PPP
SeanHoWB Apr 11, 2022
6e8b2ac
shorten PPP Sean furhterer
SeanHoWB Apr 11, 2022
05e83a2
Merge pull request #225 from SeanHoWB/Sean-PPP
SeanHoWB Apr 11, 2022
78eae54
Cut even more words in PPP
Apr 11, 2022
c0022ff
Merge pull request #226 from limjierui/Branch-FutherCutPPP2
limjierui Apr 11, 2022
0c2b230
Trim PPP further
khseah55 Apr 11, 2022
177d733
Final cut PPP
Apr 11, 2022
e13ffca
coming soon feature
SeanHoWB Apr 11, 2022
e8bf23e
Merge pull request #228 from limjierui/Branch-FinalCutPPP
limjierui Apr 11, 2022
d381bb2
Trim PPP for the last time
khseah55 Apr 11, 2022
8e5b49d
Merge branch 'master' into kitHan-TrimPPPFurther
khseah55 Apr 11, 2022
0348da5
Merge pull request #229 from SeanHoWB/Sean-UG-fixes
SeanHoWB Apr 11, 2022
f3a095a
Merge branch 'master' into kitHan-TrimPPPFurther
khseah55 Apr 11, 2022
72f35e2
Merge pull request #227 from khseah/kitHan-TrimPPPFurther
khseah Apr 11, 2022
fb0f99c
changed app to application
SeanHoWB Apr 11, 2022
d8586ec
Update Update Credit Card command for duplicate card
GlendonNotGlen Apr 11, 2022
abf9b3b
Merge branch 'master' into branch-Glendon-FixUpdateCC
GlendonNotGlen Apr 11, 2022
f088be1
Update for coding standards
GlendonNotGlen Apr 11, 2022
a5a9c63
Update JUnit testing for update CC command
GlendonNotGlen Apr 11, 2022
7e6d54e
Merge pull request #231 from GlendonNotGlen/branch-Glendon-FixUpdateCC
GlendonNotGlen Apr 11, 2022
aa783eb
intro to Commands
SeanHoWB Apr 11, 2022
4e887e2
Add validators for reading save file
Apr 11, 2022
6b7035a
more formatting
SeanHoWB Apr 11, 2022
ada588e
more formatting of content page
SeanHoWB Apr 11, 2022
0ea88c3
Update About Us with link to Dan PPP
Apr 11, 2022
d3eec6f
KH ask me to superscript
SeanHoWB Apr 11, 2022
02525c3
cont page intro to commands
SeanHoWB Apr 11, 2022
dab804f
Merge pull request #213 from danbaterisna/add-testing-instructions
danbaterisna Apr 11, 2022
b38f8c1
null input credit card fix
SeanHoWB Apr 11, 2022
d723b5e
Update docs/UserGuide.md
SeanHoWB Apr 11, 2022
e918aac
Merge pull request #230 from SeanHoWB/Sean-UG-fixes
SeanHoWB Apr 11, 2022
3768b35
null input credit card fix fixes
SeanHoWB Apr 11, 2022
360de3f
Merge pull request #233 from SeanHoWB/Sean-Bugs-3hrs-to-deadline
SeanHoWB Apr 11, 2022
ab5c33e
Correct spacing
Apr 11, 2022
8fe9bb3
Standardise sequence and class diag format
Apr 11, 2022
2443d60
Finalize UG
khseah55 Apr 11, 2022
0235f7a
Update sequence diagram
GlendonNotGlen Apr 11, 2022
f94a174
Merge pull request #235 from khseah/kitHan-FinalizeUG
khseah Apr 11, 2022
cdc7bce
Merge pull request #236 from GlendonNotGlen/master
GlendonNotGlen Apr 11, 2022
d042663
Shift calculate cashback to under CreditCard
khseah55 Apr 11, 2022
2fff919
Fix colour of diagram
Apr 11, 2022
ee7d597
Merge pull request #237 from khseah/kitHan-FinalizeUG
khseah Apr 11, 2022
0d56941
Minor edit to UG
GlendonNotGlen Apr 11, 2022
0a2c989
Merge branch 'master' into master
GlendonNotGlen Apr 11, 2022
4b4da22
fix line
SeanHoWB Apr 11, 2022
fd20e16
fix lines
SeanHoWB Apr 11, 2022
4a7d058
fix lines
SeanHoWB Apr 11, 2022
c4db4d3
fix lines again
SeanHoWB Apr 11, 2022
3902b93
Fix diagrams
Apr 11, 2022
e0af824
Merge branch 'master' into Branch-StandardiseDGDiag
Apr 11, 2022
07e3175
fix some bugs
SeanHoWB Apr 11, 2022
6970464
Merge pull request #234 from limjierui/Branch-StandardiseDGDiag
limjierui Apr 11, 2022
0635adf
Merge pull request #238 from SeanHoWB/Sean-Bugs-1hr-to-deadline
SeanHoWB Apr 11, 2022
b120b8b
fix regex
SeanHoWB Apr 11, 2022
4e6ac67
Merge pull request #239 from SeanHoWB/Sean-Bugs-lessthan-1hr-to-deadline
SeanHoWB Apr 11, 2022
4e1d5ab
fix 1mil
SeanHoWB Apr 11, 2022
97148f1
fixed ug to match 1 mil
SeanHoWB Apr 11, 2022
1547db2
Add max_income limit
khseah55 Apr 11, 2022
9682b77
Merge branch 'master' into kitHan-setMaxIncomeAmount
khseah55 Apr 11, 2022
7f9cfe9
Merge branch 'master' into validate-saved-info
danbaterisna Apr 11, 2022
7434f2f
fixed ug to match 1 mil
SeanHoWB Apr 11, 2022
ce44a7d
Migrate PropertyList to data package
Apr 11, 2022
98424f7
Merge pull request #240 from SeanHoWB/Sean-Bugs-lessthan-1hr-to-deadline
SeanHoWB Apr 11, 2022
9b38e82
fixed bug of startwith
SeanHoWB Apr 11, 2022
65efa25
Merge pull request #232 from danbaterisna/validate-saved-info
SeanHoWB Apr 11, 2022
06f73e4
Merge pull request #242 from SeanHoWB/Sean-Bugs-lessthan-1hr-to-deadline
SeanHoWB Apr 11, 2022
f107049
Check for invalid income amount
khseah55 Apr 11, 2022
fd2615f
change dan face
SeanHoWB Apr 11, 2022
7e08a0d
Merge branch 'master' of https://github.com/AY2122S2-CS2113T-T10-4/tp…
khseah55 Apr 11, 2022
f873874
change dan face
SeanHoWB Apr 11, 2022
bc323ea
Merge pull request #243 from SeanHoWB/Sean-Bugs-lessthan-1hr-to-deadline
SeanHoWB Apr 11, 2022
1b7eaa6
Merge pull request #241 from khseah/kitHan-setMaxIncomeAmount
khseah Apr 11, 2022
ab65695
change dan face pt 2
SeanHoWB Apr 11, 2022
fb96c07
Merge pull request #244 from SeanHoWB/Sean-help_me
SeanHoWB Apr 11, 2022
02c51ee
Minor changes to command classes
Apr 11, 2022
79b63c0
Merge pull request #245 from limjierui/Branch-LastChanges
limjierui Apr 11, 2022
796c151
Rename GlendonNotGlen.md to glendonnotglen.md
GlendonNotGlen Apr 13, 2022
2de331c
Update AboutUs.md
GlendonNotGlen Apr 14, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@ bin/

/text-ui-test/ACTUAL.txt
text-ui-test/EXPECTED-UNIX.TXT
list.txt
/src/main/java/META-INF
Binary file added MindMyMoney.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Duke project template

This is a project template for a greenfield Java project. It's named after the Java mascot _Duke_. Given below are instructions on how to use it.
This is a project template for a greenfield Java project. It's named after the Java mascot _Duke_. Given below are instructions on how to use it

## Setting up in Intellij

Expand Down
Binary file added UML_Diagrams.pptx
Binary file not shown.
3 changes: 2 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ test {
}

application {
mainClassName = "seedu.duke.Duke"
mainClassName = "seedu.mindmymoney.MindMyMoney"
}

shadowJar {
Expand All @@ -43,4 +43,5 @@ checkstyle {

run{
standardInput = System.in
enableAssertions = true
}
14 changes: 7 additions & 7 deletions docs/AboutUs.md
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# About us

Display | Name | Github Profile | Portfolio
--------|:----:|:--------------:|:---------:
![](https://via.placeholder.com/100.png?text=Photo) | John Doe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Joe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Ron John | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | John Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
![](https://via.placeholder.com/100.png?text=Photo) | Don Roe | [Github](https://github.com/) | [Portfolio](docs/team/johndoe.md)
| Display | Name | Github Profile | Portfolio |
|:--------------------------------------------------:|:----------------|:-------------------------------------------:|:---------------------------------:|
| [](https://via.placeholder.com/100.png?text=Photo) | Dan Baterisna | [Github](https://github.com/danbaterisna) | [Portfolio](docs/team/johndoe.md) |
| [](https://via.placeholder.com/100.png?text=Photo) | Glendon Ng | [Github](https://github.com/GlendonNotGlen) | [Portfolio](docs/team/johndoe.md) |
| [](https://via.placeholder.com/100.png?text=Photo) | Lim Jie Rui | [Github](https://github.com/limjierui) | [Portfolio](docs/team/johndoe.md) |
| [](https://via.placeholder.com/100.png?text=Photo) | Seah Kit Han | [Github](https://github.com/khseah) | [Portfolio](docs/team/johndoe.md) |
| [](https://via.placeholder.com/100.png?text=Photo) | Sean Ho Wen Bin | [Github](https://github.com/SeanHoWB) | [Portfolio](docs/team/johndoe.md) |
144 changes: 142 additions & 2 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,150 @@

{list here sources of all reused/adapted ideas, code, documentation, and third-party libraries -- include links to the original source as well}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no overview summary of what the software is all about


## Design & implementation
## Design

{Describe the design and implementation of the product. Use UML diagrams and short code snippets where applicable.}
### Architecture
![architecture diagram](images/architecture_diagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The architecture diagram does not have to connection between Parser and Commands, while the command diagram indicates otherwise.
image
image

<br/> Fig 1 - Architecture Diagram

The Architecture Diagram above shows the high-level design of the application. The **main components**
consist of:
- `MMM`: Initialises the components in the correct sequence and connects them with each other. Also holds the user's
expenditures in memory.
- `Ui`: The User Interface of the application and deals with interaction with the user.
- `Parser`: Deals with making sense of user commands.
- `Commands`: The collection of all executable commands.
- `Storage`: Reads data from, and writes data to the hard disk.

By abstracting out closely related code into classes, it allows`MMM`to deal at a higher level, without worrying
about the lower level details. Higher cohesion is also achieved and coupling is minimized as each component is
only coupled to the main class,`MMM`.

The Sequence Diagram below shows an example of how the components interact with each other for the scenario
where the user issues the command`add shoes 100`.

![sequence_diagram](images/sequence_diagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent diagram that shows a high-level overview of how the application works. Colouring to differentiate the different components are also good!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sequence diagram, shouldn't the user go to :MMM with thecommand add shoes before the :Ui?
The sequence feels a bit off here

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they are trying to illustrate that the user enters the command through :UI, which is then sent to :MMM to handle, which will then parse and do the rest of the sequence.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of color schemes to make the sequence and architecture diagrams more visually appealing and easy to follow through!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No critique here, just a really nice diagram sequence that details the architecture of your program!

<br/> Fig 2 - Sequence Diagram

The sections below give more details for each component.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no termination, loop, opt, etc. in the sequence diagram
Tutorial Week 11 Screenshot 6b


<br/>

### UI component
The source code can be found in [Ui.java](https://github.com/AY2122S2-CS2113T-T10-4/tp/blob/master/src/main/java/seedu/mindmymoney/Ui.java)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you guys include the link for source code in the DG

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good that there's a source code hyperlink to the Github website


![ui_diagram](images/ui_diagram.png)
<br/> Fig 3 - Ui Diagram

The UI component consists of a`Ui`and`PrintStrings`class.

The UI component:
- Prints the welcome banner and message on startup, as well as a financial tip from the`PrintStrings`class.
- Prints`>`before the user's input, to help the user differentiate between their input and an output from the
application.
- Reads input from the user.

<br/>

### Parser component
The source code can be found in [Parser.java](https://github.com/AY2122S2-CS2113T-T10-4/tp/blob/master/src/main/java/seedu/mindmymoney/Parser.java)

![parser_diagram](images/parser_diagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to clarify this diagram? It is a bit confusing because a package named Parser is used. But the code architecture does not have a package named parser. Would it be possible to rename it to a more suitable name like ExpenditureTracker? Because it houses not only parser, but also the other aspects like the ExpenditureList, Functions as well as Parser

<br/> Fig 4 - Parser Diagram

The Parser component consists of a`Parser`, `Functions`, `ExpenditureList` and `Expenditure`class

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The labeling of figures may be better if placed above the diagram itself.
Why is the Function class separate from the Parser Class?


The Parser component:
- Receives user's input and splits it into the Command Type and Description using the`Functions`class.
- Uses the`itemList`, which is an`ExpenditureList`object, to instantiate a`Command`object based on the Command Type.
- Returns the`Command`object that can then be executed.

We pass in the`itemList`to the`Command`object instead of using a global variable to ease testing. This way, we can
add, delete and update`Expenditure`entries in a new`itemList`during testing without affecting the actual`itemList`.

### Command component
The source can be found in [command](https://github.com/AY2122S2-CS2113T-T10-4/tp/blob/master/src/main/java/seedu/mindmymoney/command)

![command_diagram](images/command_diagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The activation bar in the sequence diagram for the Command:AddCommand is too long
image

Copy link

@Musfirahe0556596 Musfirahe0556596 Mar 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diagram is understandable as it shows the different commands available but perhaps an improvement that could be done is to add in the abstract method execute() also to show that all command types have this method in their own classes?

<br/> Fig 5 - Command Diagram

The Command component consists of `Command` abstract class, `AddCommand`, `ByeCommand`, `DeleteCommand`, `HelpCommand`
, `ListCommand`and `UpdateCommand` that extends the `Command` class.

The Command component:
- Provides all the Command classes which can be instantiated by `Parser.parseCommand()`. The Command objects can then be
executed. Only 1 Command object can be created.
- Includes a `.executeCommand()` method in each Command classes which performs the relevant command and throws
exceptions if an error is encountered. The error is then handled.

### Storage component
The source can be found in [Storage.java](https://github.com/AY2122S2-CS2113T-T10-4/tp/blob/master/src/main/java/seedu/mindmymoney/Storage.java)

![storage_diagram](images/storage_diagram.png)
<br/> Fig 6 - Storage Diagram

The Storage component consists of `Storage` class.

The Storage component:
- `MMM` class initialises a `Storage` object upon start up. The `Storage` class consists of
`load()` and `save()` methods.
- Concurrently, `MMM` will call the `load()` method and load any data that is stored on the hard disk.
- `MMM` calls the `save()` method and stores remaining data onto the hard disk when the program exits.


## Implementation
This section describes some noteworthy details on how certain features are implemented.

### Add Command Feature
#### Current Implementation
The sequence diagram below shows the interactions of different subcomponents of the system when adding an expenditure
to the list.
![add_command_sequence_diagram](images/Add_Command_Sequence_Diagram.png)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there should be an activation bar on the call to the AddCommandInputTest#test(...) method as shown in the screenshot?:
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the return values should include the data type e.g. category: String

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to all the return value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to enter the objectName:Datatype format for the return types?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-04-01 at 10 22 27 AM

Shouldn't the return arrow be outside of the alt frame?

A key functionality of MindMyMoney is the ability to add and track user expenditure. A user can add in a new expenditure
by specifying the payment type, the category, the description of the item, the cost of the item and the date and the
month purchased.

1. The `Parser` component parses user input and returns the new `AddCommand` object to the
`MindMyMoney`.
2. `AddCommand` instantiates `addInput`, `expenditureList` and `creditCardList`.
3. The application invokes `Addcommand.execute` to execute user instruction.
4. During the execution, `Addcommand.execute` will parse through user input to obtain the `EXPENDITURE`, `CATEGORY`,
`DESCRIPTION`, `AMOUNT` and `TIME` fields.
5. The `Addcommand` object instantiates a new `Expenditure` object with the aforementioned 5 fields and adds them

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps there should be another line to describe what the AddCommandInputTest#test(...) method does?

into the `ExpenditureList`.
6. The `Addcommand` object prints a list to show the user what it has saved.

#### Design considerations
Aspect: How to ask user for the 5 fields of input
* Alternative 1 (current choice): User is asked to put in all 5 fields at once, separated using flags.
* Pros: Faster input, user can enter an expenditure using a single input.
* Cons: User must be able to remember all the flags and its sequence.

* Alternative 2: User is asked iteratively to put in all 5 fields, prompted by a message after each input.
* Pros: Beginner friendly, easily understandable, no need to remember flags.
* Cons: Slower, implementation when user is familiar with the application.

### Calculate Command feature

To enable users to view their finances in a more meaningfully, MindMyMoney does calculations to present financial data
that is actionable for the users.

![calculate_command_sequence_diagram](images/gif_loading.gif)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if the gif is supposed to be an indication of 'to be updated' as here it states that the picture is supposed to be a sequence diagram, but no sequence diagram is shown xD.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not know why you guys put loading gif here but I think it should be a sequence diagram
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it was intended but just curious why haha

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also curious about the loading gif! Is it a picture that was not rendered?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calculate command sequence diagram is not loading maybe because it is a .gif instead of a .png image
Tutorial Week 11 Screenshot 5b


### List Command feature
To enable users to view their current list of added expenditures.

#### Design considerations
Aspect: How to make the list command easily tested using JUnit testing
* Alternative 1 (current choice): Abstract the conversion of Expenditure to String in a separate listToString() method
* Pros: Easily tested using JUnit testing, by checking the String that the listToString() method returns
* Cons: Added layer of abstraction that may be deemed redundant

* Alternative 2: Print directly in the ListCommand.executeCommand() method
* Pros: Easily implemented with lesser lines of code as the code is minimalist
* Cons: JUnit testing would require I/O redirection prior to checking the output matches expectations

![list_command_sequence_diagram](images/List_Command_Sequence_Diagram.png)

## Product scope
### Target user profile

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target User is unknown so it is unclear who this software is for

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no information in the product scope, non-functional requirement, glossary and instruction for manual testing sections.
image
image

Expand Down
19 changes: 17 additions & 2 deletions docs/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,21 @@
# Duke
# MindMyMoney (M<sup>3</sup>)

{Give product intro here}
MindMyMoney (M3) was proposed for users with multiple payment methods who wish to track their expenditures. Conducting
anecdotal interviews, we realized users face difficulty tracking their expenditures across different payment platforms
on vastly different items. MindMyMoney was then conceptualized on the basis of tracking user’s expenditures.<br>

The technical goal for the MindMyMoney (M3) is to develop an app for managing your expenditures, optimized for use via
a Command Line Interface (CLI). M3 aims to be a one-stop shop for you to consolidate your expenditure across multiple
platforms, set budget goals and track your spending.


# Quick Start

1. Ensure that you have Java 11 or above installed.
2. Down the latest version of `MindMyMoney` from [here](https://github.com/AY2122S2-CS2113T-T10-4/tp/releases).

If the setup is correct, you should see something the following in your terminal:
![start screenshot](./images/start.PNG)<br>

Useful links:
* [User Guide](UserGuide.md)
Expand Down
Loading