[Mark Lin] iP #66
Open
[Mark Lin] iP #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woodenclock
reviewed
Sep 6, 2023
lctxct
reviewed
Sep 6, 2023
exetr
reviewed
Sep 17, 2023
src/main/java/Duke.java
Outdated
| out = "List is empty."; | ||
| } | ||
| for (int i = 0; i < listAsArray.length; i++) { | ||
| out += (i == 0 ? "" : "\n") + (i + 1) + ". " + listAsArray[i].getListText(); |
There was a problem hiding this comment.
Try to avoid complicated expressions such as this, consider especially the usage of ternary operators in such contexts, as more complicated comparisons may affect the code readability.
src/main/java/Duke.java
Outdated
Comment on lines
81
to
101
| switch (line[0]) { | ||
| case "T": { | ||
| Task task = new Todo(taskName); | ||
| task.setIsComplete(isMark); | ||
| list.add(task); | ||
| break; | ||
| } | ||
| case "D": { | ||
| String by = line[3]; | ||
| Task task = new Deadline(taskName, by); | ||
| task.setIsComplete(isMark); | ||
| list.add(task); | ||
| break; | ||
| } | ||
| case "E": { | ||
| String from = line[3].split("-")[0]; | ||
| String to = line[3].split("-")[1]; | ||
| Task task = new Event(taskName, from, to); | ||
| task.setIsComplete(isMark); | ||
| list.add(task); | ||
| break; |
There was a problem hiding this comment.
Consider further abstracting out the logic in this portion of the code to avoid deep nesting
src/main/java/Duke.java
Outdated
Comment on lines
96
to
97
| String from = line[3].split("-")[0]; | ||
| String to = line[3].split("-")[1]; |
There was a problem hiding this comment.
Try to avoid usage of magic literals, especially in larger projects, in this case, consider assigning your delimiter to a variable, then referencing when needed.
src/main/java/Duke.java
Outdated
| throw new DukeException("The description of " + command + " cannot be empty."); | ||
| } | ||
| return message.substring(command.length(), | ||
| message.contains("/") ? message.indexOf("/") : message.length()).trim(); |
There was a problem hiding this comment.
Similarly, keep aware of the usage of magic literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.