-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lim Yee Kian] iP #154
Open
yeekian
wants to merge
98
commits into
nus-cs2113-AY2425S1:master
Choose a base branch
from
yeekian:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Lim Yee Kian] iP #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
Remove all traces of Duke from the source code. Rename Duke.java to Mel.java. Replace Duke with Mel in Mel.java and README.md. Ensure chatbot name consistency.
The chatbot cannot store and list user-entered text. Create class to store entered text and display them to user when requested. No disk storage used due to focus on temporary session-based interactions.
Use List class to store user text and print list when requested.
Task are strings in an array in List class. Incorporating additional information such as isDone status will be increasingly complex. Let's create a new Task class to contain task related attributes and methods. This is a more natural representation of the tasks.
Todo extends Task class. Class overrides the toString method to print out special description of the Todo task.
Deadline extends Task class. On top of the description attribute in Task, it also contains the String by attribute to store the deadline as a string. Class overrides the toString method to print out special description of the Deadline task.
Event extends Task class. On top of the description attribute in Task, it also contains the String startDate and String endDate attributes to store the start and end date or timings of the event. Class overrides the toString method to print out special description of the Event task.
Modify addItem method to add Todo, Deadline, and Event class objects into the list of Tasks.
This reverts commit 4fb8933.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.