[ZiliaAJY] iP #26

ZiliaAJY · 2024-08-31T15:44:20Z

No description provided.

- Implement Task class for managing tasks - Add Conglo$Task.class file and Conglo.class file

- Refined method and variable names for consistency and clarity - Adjusted layout and spacing for improved readability

- Add 'Task.java', 'Deadline.java', 'Todo.java' and 'Event.java' files - Implement classes Todo, Deadline and Event classes to inherit from a Task class

- Refactored method names and constants for improved clarity - Added JavaDoc comments to Task, Deadline, Event, and Todo classes - Included class-level documentation and descriptions for constructors and methods. - Documented parameters, return values, and method behaviors

Chiang-HuiXin

Good job! Overall, I think that your code is very neat and readable. There are good abstractions and documentation.

Chiang-HuiXin · 2024-09-04T04:15:12Z

src/main/java/Conglo.java

+            Todo todo = new Todo(words[1]);
+            taskList[taskCount] = todo;
+            taskCount++;


Maybe put this in a method?

Chiang-HuiXin · 2024-09-04T04:18:16Z

src/main/java/Conglo.java

+     *
+     * @param args Command-line arguments (not used).
+     */
+    public static void main(String[] args) {


I like how your main method is short!

Chiang-HuiXin · 2024-09-04T04:24:12Z

src/main/java/Task.java

+        return (isDone ? "X" : " "); // mark done task with X
+    }
+
+    public void markAsDone() {


Maybe name it as "setMarkAsDone" since it is a setter?

Chiang-HuiXin · 2024-09-04T04:28:49Z

src/main/java/Deadline.java

+    /**
+     * Returns a string representation of the Deadline task.
+     * The format includes a label for deadlines, the task's completion status,
+     * description, and the deadline date.
+     *
+     * @return A string representation of the Deadline task.
+     */


I like that you do documentation, it really makes the code much more readable!

seanngja · 2024-09-04T05:26:51Z

src/main/java/Conglo.java

+    /**
+     * Prints a line separator to the console.
+     */


I like how you have added comments that describe what each function does.

seanngja · 2024-09-04T05:31:16Z

src/main/java/Conglo.java

+    public static void main(String[] args) {
+        greetUser();
+        Scanner scanner = new Scanner(System.in);
+        Task[] listing = new Task[MAX_TASKS];
+        command = scanner.nextLine();
+        while (!command.equals("bye")) {
+            processCommand(command, listing);
+            command = scanner.nextLine();
+        }
+        scanner.close();
+        sayGoodbye();
+    }


I like how your main function is readable and easy to follow!

seanngja · 2024-09-04T05:36:18Z

src/main/java/Conglo.java

+     */
+    public static void processCommand(String command, Task[] taskList) {
+        String[] words = command.split(" ", 2);
+        switch(words[0]) {


Your switch case indentation looks good, great job!

seanngja · 2024-09-04T05:37:36Z

src/main/java/Conglo.java

+            echoTask(todo);
+            break;
+        case "deadline":
+            addDeadline(words[1], taskList);


I like that your functions are named concisely and easy to understand.

- Renamed paths in runtest.bat - Added new tasks and commands to test various functionalities, including: - Adding and listing tasks - Marking tasks as done - Handling multiple commands in sequence

-Contains Conglo's custom exception including unknown command, missing description, invalid or missing task number and invalid format

- Use base CongloException for common exception handling - Added internal try-catch block to handle specific exceptions - Improved error handling and message output

- Created packages "conglo", "conglo,exception", "conglo.manual" and "conglo.task"

- Save tasks automatically to the hard disk whenever the task list is modified. - Load tasks from the hard disk when the application starts, ensuring persistence across sessions. - Hard-coded file path and name for storage: './data/conglo.txt'. - Added error handling for file I/O operations to manage file creation and loading processes.

- Replaced all instances of normal arrays with ArrayLists for better flexibility. - Implemented functionality to delete tasks from the list.

Add task deletion functionality - Implement support for deleting tasks from the list. - Update task management to handle deletions correctly. - Ensure task list updates reflect changes immediately.

- Resolved conflicts in Task.java - Resolved conflicts in Conglo.java Description of changes made to resolve conflicts: - Fixed discrepancies in file paths and format between branches - Refactor Task class and its children class to adopt new format for saving of tasks

- Save tasks automatically to the hard disk whenever the task list is modified. - Load tasks from the hard disk when the application starts, ensuring persistence across sessions. - Hard-coded file path and name for storage: './data/conglo.txt'. - Added error handling for file I/O operations to manage file creation and loading processes.

Merge branch-Level-7 to include Save function

okkhoy

There are a few coding standards and code quality violations in the code. Please try to fix them before the final submission.

okkhoy · 2024-09-25T05:48:50Z